Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 263182

Summary: [CSS] Need CTabFolder custom properties (group 1)
Product: [Eclipse Project] e4 Reporter: Kevin McGuire <Kevin_McGuire>
Component: UIAssignee: Aghiles Abdesselam <aghilesa>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 0.9   
Target Milestone: 0.9 M2   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Bug Depends on: 265214    
Bug Blocks:    
Attachments:
Description Flags
added CTabFolder properties
none
added CTabFolder properties with junits none

Description Kevin McGuire CLA 2009-02-01 18:37:29 EST 
We need the following properties on CTabFolder (that is, they should be settable by these properties names from a stylesheet).

  borderVisible: boolean;
  simple: boolean;
  maximizeVisible: boolean;
  minimizeVisible: boolean;

See CTabFolder setters/getters with corresponding names.

This is group 1 of 2 and represent the high priority ones needed to do the photo demo.
Comment 1 Aghiles Abdesselam CLA 2009-02-09 16:13:02 EST 
also 

showClose: boolean; (found in CTabItem)
Comment 2 Aghiles Abdesselam CLA 2009-02-12 10:43:44 EST 
Created attachment 125529 [details]
added CTabFolder properties
Comment 3 Aghiles Abdesselam CLA 2009-02-12 14:05:38 EST 
Created attachment 125558 [details]
added CTabFolder properties with junits
Comment 4 Kevin McGuire CLA 2009-02-16 22:09:07 EST 
1) This patch includes classes like ICSSPropertyMaximizedHandler declared in css.core.

The methods defined in css.core should be general to CSS support (e.g. in a web browser).  Maximization, and the others, aren't such a concepts.

But then, I'm not sure of their role. CSSPropertyMaximizedSWTHandler doesn't implement it, nor does any other class from this patch.

Is there a way to add new property types without adding them to css.core?

2) On a more minor note, many of the implementation classes in css.swt are in css.swt.properties.css2 (e.g. CSSPropertyMaximizedSWTHandler).  I believe the intention of this package is for holding properties defined in the CSS2 specification.  These properties are not, they're our extensions.

Maybe we should create a package org.eclipse.e4.ui.css.swt.custom to hold them.

3) CSSPropertyBackgroundColorHandler appears to only have white space changes.  If so, please exclude from patch.
Comment 5 Aghiles Abdesselam CLA 2009-02-17 15:58:46 EST 
Comment on attachment 125558 [details]
added CTabFolder properties with junits

Patch will be included in bug 265214
Comment 6 Kevin McGuire CLA 2009-02-17 18:43:50 EST 
Closed as part of bug #265214