Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 262924

Summary: api.tools.ui should have a dependency on org.eclipse.equinox.p2.ui.sdk
Product: [Eclipse Project] PDE Reporter: Olivier Thomann <Olivier_Thomann>
Component: API ToolsAssignee: Olivier Thomann <Olivier_Thomann>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Michael_Rennie
Version: 3.5   
Target Milestone: 3.5 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 263690    
Bug Blocks:    
Attachments:
Description Flags
Proposed fix none

Description Olivier Thomann CLA 2009-01-29 11:48:10 EST
The link used to open the "Install New Software..." dialog requires a dependency on org.eclipse.equinox.p2.ui.sdk in order to get the command used to open the dialog.
This dependency is missing which means that in a launching configuration the bundle org.eclipse.equinox.p2.ui.sdk won't be selected when clicking on "Add Required Plug-ins".
Comment 1 Michael Rennie CLA 2009-01-29 12:18:55 EST
I don't think we should have a dep on a bundle we don't use. 

The only 'use' of the bundle is that our install link tries to find the command handler to open the p2 install UI. We could simply add a check on the page that if we cannot get the command handler (i.e. p2 is not available / installed) then the user is not bale to install more descriptions.
Comment 2 Olivier Thomann CLA 2009-02-04 14:27:50 EST
Right, the link creation should be conditional to the command handler being available. We should also handle the case where the handler command cannot be executed properly.
Comment 3 Olivier Thomann CLA 2009-02-04 15:23:47 EST
Created attachment 124727 [details]
Proposed fix
Comment 4 Olivier Thomann CLA 2009-02-04 15:24:36 EST
Released for 3.5M6.
Michael, please verify.
Comment 5 Olivier Thomann CLA 2009-02-05 10:20:55 EST
Without a fix for bug 263690, if a failure occurs on the first click on the link, there is no feedback to the user.
Comment 6 Michael Rennie CLA 2009-02-05 10:27:37 EST
verified