| Summary: | api.tools.ui should have a dependency on org.eclipse.equinox.p2.ui.sdk | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Olivier Thomann <Olivier_Thomann> | ||||
| Component: | API Tools | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | Michael_Rennie | ||||
| Version: | 3.5 | ||||||
| Target Milestone: | 3.5 M6 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 263690 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Olivier Thomann
I don't think we should have a dep on a bundle we don't use. The only 'use' of the bundle is that our install link tries to find the command handler to open the p2 install UI. We could simply add a check on the page that if we cannot get the command handler (i.e. p2 is not available / installed) then the user is not bale to install more descriptions. Right, the link creation should be conditional to the command handler being available. We should also handle the case where the handler command cannot be executed properly. Created attachment 124727 [details]
Proposed fix
Released for 3.5M6. Michael, please verify. Without a fix for bug 263690, if a failure occurs on the first click on the link, there is no feedback to the user. verified |