Bugzilla – Full Text Bug Listing
| Summary: | query dialog size does not get saved | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Thomas Ehrnhoefer <thomas.ehrnhoefer> | ||||||
| Component: | Mylyn | Assignee: | Mylyn Inbox <mylyn-inbox> | ||||||
| Status: | RESOLVED NOT_ECLIPSE | QA Contact: | |||||||
| Severity: | trivial | ||||||||
| Priority: | P4 | CC: | robert.elves, steffen.pingel | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| URL: | https://studio.atlassian.com/browse/PLE-897 | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 262107 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Thomas Ehrnhoefer
Let's look over this together. There is probably already some code in AbstractQueryPage2 to handle this. There does not seem to be anything in AbstractRepositoryQueryPage(2), the Bugzilla query page is handling that itself ( org.eclipse.mylyn.internal.bugzilla.ui.search.BugzillaSearchPage.saveBounds(Rectangle) ). It seems pretty generic to me, so my suggestion would be to pull that up to the org.eclipse.mylyn.tasks.ui.wizards.AbstractRepositoryQueryPage to make it available for all query dialogs? That sounds good. I would prefer to only make changes to AbstractRepositoryQueryPage2 to encourage connectors to use that. I would like to deprecate the older implementation at some point. As per our discussion we need to determine first if setting the size of the shell in the wizard page is the right approach. This can cause some strange behavior in the search dialog where switching to the tasks tab causes the dialog to get moved (see also bug 262107). I have put this on the agenda for next weeks meeting. Created attachment 123840 [details]
temp patch
This patch pulls up the behaviour of Bugzilla's query dialog into the AbstractRepositoryQueryPage(2).
Although given the previous comments, the behaviour most likely will not stay the same...so it"s just a patch for not loosing this work...
Created attachment 123841 [details]
mylyn/context/zip
As per discussion with Rob we should come up with an implementation that handles the persistence of the dialogs bounds in the dialog itself and not in the page. We may need to extend AbstractRepositoryQueryPage to allow a per page setting for the bounds. So this is not a JIRA issue then I guess? I can still work on it, but it is UI in my opinion (as is Bug 265348) The Mylyn JIRA Connector has moved to Atlassian. All unresolved Mylyn bugs assigned to the JIRA component, which includes this bug, have been copied to https://studio.atlassian.com/browse/PLE and marked as resolved on bugs.eclipse.org. The new location of this bug report can be found in the URL field. Please see this FAQ entry for further details: http://wiki.eclipse.org/Mylyn/FAQ#What_happened_to_the_Mylyn_JIRA_Connector.3F . |