Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 260831

Summary: Targetplatfrom materializer doesn't materialize platform specific bundles
Product: z_Archived Reporter: Markus Kuppe <bugs.eclipse.org>
Component: BuckminsterAssignee: buckminster.core-inbox <buckminster.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: thomas
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch p1
thomas: iplog+
mylyn/context/zip
none
patch p2
none
mylyn/context/zip none

Comment 1 Markus Kuppe CLA 2009-01-13 05:47:32 EST 
Created attachment 122394 [details]
patch p1

A first (rough) take on this issue.

@Thomas what's the best way to get the list of excluded/skipped bundles (set e.g. in the CQUERY) from the materialization context in org.eclipse.buckminster.core.materializer.PlatformIgnoringFeature.getPluginEntries()?
Comment 2 Markus Kuppe CLA 2009-01-13 05:47:37 EST 
Created attachment 122395 [details]
mylyn/context/zip
Comment 3 Markus Kuppe CLA 2009-01-15 02:50:47 EST 
A few implementation details...

For a minute I favored to move org.eclipse.buckminster.core.materializer.TargetPlatformMaterializer.convertFeature(IFeature, MaterializationContext) into an adapter factory. But then the context would require a setter on PlatformIgnoringFeature.

PlatformIgnoringFeature might be better named PlatformIndependetFeature.
Comment 4 Thomas Hallgren CLA 2009-01-16 07:11:36 EST 
Patch applied. Thanks.
Comment 5 Markus Kuppe CLA 2009-01-16 07:24:07 EST 
Thomas, you're with the hard coded stuff in org.eclipse.buckminster.core.materializer.PlatformIgnoringFeature.getPluginEntries()?
Comment 6 Thomas Hallgren CLA 2009-01-16 07:35:17 EST 
(In reply to comment #5)
> Thomas, you're with the hard coded stuff in
> org.eclipse.buckminster.core.materializer.PlatformIgnoringFeature.getPluginEntries()? 
> 
Yes. I cannot see any harm with it at this point. The problem will eventually go away anyway since the whole matter of installing features will be replaced by P2.
Comment 7 Markus Kuppe CLA 2009-01-16 08:15:27 EST 
Created attachment 122801 [details]
patch p2

Here's a revised/much cleaner implementation that uses an AdapterFactory in TargeTPlatformMaterialization.
Comment 8 Markus Kuppe CLA 2009-01-16 08:15:31 EST 
Created attachment 122802 [details]
mylyn/context/zip