Bug 259581

Description Philippe Coucaud 2008-12-23 11:54:13 EST

Build ID: I20081211-1908

1. Select a file in a project, then select Export > General / Archive File, and press Next : the selected file is checked in the tree viewer and the Finish button is disabled.
2. Enter the name of the output file: Finish button becomes enabled
3. Uncheck the selected file: Finish button becomes disabled and an error is generated (no resources selected to export).
4. Recheck the file to export: Finish button is enabled again. So far so good.
5. Press Deselect All: selected file properly gets unchecked but the Finish button remains enabled and no error is displayed.
6. Press Finish and you get an error: Zip file must have at least one entry.


The reason for the inconsistent state at step 5 is because WizardExportResourcesPage.updateWidgetEnablements() is only called at initialization and when a CheckStateChangedEvent is triggered in the TreeViewer. However, Select All, Deselect All and Filter Types ... buttons do manipulate the tree viewer's state without triggering any CheckStateChangedEvent.

WizardFileSystemResourceImportPage1 properly handles a similar scenario by explicitly calling updateWidgetEnablements() on selection events from both the Select All and Deselect All buttons:

[...]
        listener = new SelectionAdapter() {
            public void widgetSelected(SelectionEvent e) {
                setAllSelections(true);
                updateWidgetEnablements();
            }
        };
        selectAllButton.addSelectionListener(listener);
[...]

whereas WizardExportResourcesPage only modifies the tree viewer:

[...]
        listener = new SelectionAdapter() {
            public void widgetSelected(SelectionEvent e) {
                resourceGroup.setAllSelections(true);
            }
        };
        selectButton.addSelectionListener(listener);
[...]