Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 259503

Summary:

[Viewers] Make PatternFilter useable for TableViewers

Product:

[Eclipse Project] Platform

Reporter:

Thomas Schindl <tom.schindl>

Component:

Assignee:

Platform UI Triaged <platform-ui-triaged>

Status:

CLOSED WONTFIX

QA Contact:

Severity:

normal

Priority:

CC:

shawn.minto

Version:

3.4

Target Milestone:

---

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

stalebug

Bug Depends on:

Bug Blocks:

259495

Attachments:

Description	Flags
patch	none

Description Thomas Schindl

2008-12-22 11:07:11 EST

Currently PatternFilter restricts itself to TreeViewer by casting internally to AbstractTreeViewer in PatternFilter#isParentMatch(). 

It would be nice if:
a) PatternFilter changes JavaDoc to state that if can also be used with 
   AbstractTableViewer

b) PatternFilter checks in isParentMatch() for the AbstractTreeViewer and returns 
   false

If you agree with this changes I'd prepare a patch.

Comment 1 Boris Bokowski

2009-01-07 23:38:37 EST

(In reply to comment #0)
> If you agree with this changes I'd prepare a patch.

Sounds good to me.

Comment 2 Boris Bokowski

2009-11-26 09:55:35 EST

Hitesh is now responsible for watching bugs in the [Viewers] component area.

Comment 3 Shawn Minto

2010-02-10 17:33:16 EST

Created attachment 158792 [details]
patch

I would like this support as well.  Here is a simple patch that just performs the instanceof check in isParentMatch instead of just casting to AbstractTreeViewer.

Comment 4 Eclipse Webmaster

2019-09-06 16:18:29 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 5 Eclipse Genie

2021-10-24 06:40:27 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.