Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 258882

Summary: Api check should also check reexported API types
Product: [Eclipse Project] PDE Reporter: Olivier Thomann <Olivier_Thomann>
Component: API ToolsAssignee: Olivier Thomann <Olivier_Thomann>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: darin.eclipse, Michael.Valenta, Michael_Rennie
Version: 3.5   
Target Milestone: 3.5 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Proposed fix
none
Proposed fix none

Description Olivier Thomann CLA 2008-12-15 18:32:53 EST 
When iterating over the types of an api component, all the reexported types should also be considered.
The following case should be reported as a breakage:
Plugin A reexports Plugin B.
B provides API types.

In the new version, A doesn't reexport B anymore. This should be reflected with API types removed from A since they were exposed through A.
Comment 1 Olivier Thomann CLA 2009-01-05 14:26:29 EST 
Created attachment 121552 [details]
Proposed fix

This patch doesn't include the regression tests which contains too many outgoing changes.
Comment 2 Olivier Thomann CLA 2009-01-05 14:29:14 EST 
*** Bug 240914 has been marked as a duplicate of this bug. ***
Comment 3 Olivier Thomann CLA 2009-01-05 15:12:03 EST 
Created attachment 121556 [details]
Proposed fix

Previous patch didn't handle well swt as a re-exported bundle.
Comment 4 Olivier Thomann CLA 2009-01-05 15:12:59 EST 
Released with regression tests in org.eclipse.pde.api.tools.builder.tests.compatibility.BundleMergeSplitTests.

Darin, please verify.
Comment 5 Darin Wright CLA 2009-01-05 16:39:49 EST 
I filed bug 259997 regarding the location of the "restrictions changed" errors (on manifest rather than associated types). However, the correct set of errors is now being generated.
Comment 6 Michael Rennie CLA 2009-03-03 10:53:54 EST 
verified