Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 257084

Summary: [Project Sets] Export psf to file system - file location validation works oddly
Product: [Eclipse Project] Platform Reporter: Kevin McGuire <Kevin_McGuire>
Component: TeamAssignee: Pawel Pogorzelski <pawel.pogorzelski1>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: pawel.pogorzelski1, Szymon.Brandys
Version: 3.4   
Target Milestone: 3.5 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Snapshot showing typed in valid path c:\temp\foo,psf failing none

Description Kevin McGuire CLA 2008-12-01 10:50:25 EST
3.5 M20080911-1700

1. File->Export->Team->Project Set
2. Select many projects
3. Keep destination as "File" (vs. Workspace)

As soon as you type anything, you get "You have specified a folder" error in the banner.
Picking "Browse" and picking a directory, giving a file name, you still get this banner error.
What is odd is that Finish is enabled yet the banner claims there is an error.  So good news is that you can actually do the export.  But it's easy to be confused and assume either you can't (because of error in banner) or that there is a system. Thus marking as major.
Comment 1 Szymon Brandys CLA 2008-12-01 11:44:28 EST
Hi Kevin, I would not say that this is "major loss of function". I've checked how it works in N20081127-2000 and it seems to work now.

You see "You have specified a folder" only if you really does it.
Comment 2 Pawel Pogorzelski CLA 2008-12-02 04:43:58 EST
Build id: I20081125-0840

I cannot reproduce the bug with steps provided by Kevin. However it is possible to provide an invalid file name (for example "?" on Windows) and the error message is not shown.
Comment 3 Pawel Pogorzelski CLA 2008-12-02 04:48:50 EST
Since I was unable to get an error message in a case a valid file is provided
I'd lower the severity.
Comment 4 Szymon Brandys CLA 2008-12-02 05:01:40 EST
Kevin, I'm changing the summary and lowering the severity. Pawel volunteered to fix it.
Comment 5 Kevin McGuire CLA 2008-12-02 13:20:02 EST
(In reply to comment #3)
> Since I was unable to get an error message in a case a valid file is provided
> I'd lower the severity.

Strange. I got it even if the destination was a correct path (ie. I could never make the message go away, even using the Browse button, which I did).  Yet in trying it now, that's not true.  Either I was imagining things before or there's some subtlety to the steps which I'm not reproducing.

Either way I'm ok lowering the severity.  I will see if I can reproduce the "always error" case I saw.

Comment 6 Kevin McGuire CLA 2008-12-02 14:27:43 EST
Got it!

1. File->Export->Team->Project Set
2. Select many projects
3. Keep destination as "File" (vs. Workspace)
4. In the File field type C:\
Observe: you will get the error about it being a folder
5. Now keep typing to change it to something valid, like C:\temp\foo.psf
Observe: it remains in the error state.  Even if you select a file via the Browse button.
Comment 7 Kevin McGuire CLA 2008-12-02 14:30:02 EST
We may want to raise priority since it essentially fails if you type instead of Browse.
Comment 8 Kevin McGuire CLA 2008-12-02 14:31:11 EST
Created attachment 119304 [details]
Snapshot showing typed in valid path c:\temp\foo,psf failing
Comment 9 Kevin McGuire CLA 2008-12-02 14:33:27 EST
(In reply to comment #8)
> Created an attachment (id=119304) [details]
> Snapshot showing typed in valid path c:\temp\foo,psf failing

c:\temp\foo.psf  that is.

Comment 10 Pawel Pogorzelski CLA 2009-02-03 05:39:07 EST
It's a duplicate of already fixed bug. That's why I wasn't able to reproduce it with the latest build.

*** This bug has been marked as a duplicate of bug 232600 ***