Bugzilla – Full Text Bug Listing
| Summary: | [editor] support customization of background color in task editor | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Ari Seo <kujeah> | ||||||||||
| Component: | Mylyn | Assignee: | Project Inbox <mylyn-triaged> | ||||||||||
| Status: | CLOSED MOVED | QA Contact: | |||||||||||
| Severity: | enhancement | ||||||||||||
| Priority: | P4 | CC: | exnadler, greensopinion, mik.kersten, php6developer, steffen.pingel | ||||||||||
| Version: | unspecified | Keywords: | helpwanted | ||||||||||
| Target Milestone: | --- | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | Windows XP | ||||||||||||
| Whiteboard: | |||||||||||||
| Bug Depends on: | 299697 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ari Seo
*** Bug 257002 has been marked as a duplicate of this bug. *** The task editor uses the default colors for Eclipse forms. Are you able to change the background color for other form based editors, e.g. PDE's plugin.xml editor? Created attachment 119111 [details]
pdt editor
when i change current line highlight to white, i should see like this in pdt editor.
see line 73
Created attachment 119112 [details]
in mylyn editor
when i change current line highlight to black, i should see like this in mylyn task editor
i type 'aaa' in "New Comment" area
When i attempt changing eclipse form based editors, it is OK. i can change background color. I do like this 1. open preferences window 2. select General > Editors > Text Editors 3. change apperence color options I change "Current line highlight" Black to White When i do like this, i can see "white" current line highlight, "black" font color, but this action change all form based editor's current line highlight to white. because i do not use plug-in development, i check this pdt editor and i can see changing current line highlight to white. this is ok, but it is not comfortable to see. I attach two screenshots when i change current line highlight to white in pdt editor and when i change current line highlight to black in mylyn task editor. maybe it does not mean background color, it means current line highlight color *** Bug 274939 has been marked as a duplicate of this bug. *** Created attachment 134484 [details]
Set highlight line color as black and forefroun color - white
Background - work, but foreground - not work
Created attachment 134488 [details]
Status whiteboard - too incorrect highlight lines!
Maybe not use background and foreground colors and use only system defaults attributes?
How to change colorize in WikiEditor? I select plain text editor and see default colorize (white background, black text). But in eclipse I configure background color on dark gray and text color - white. This dark gray color I see in WikiText editor. But I see black text color (not white). Please - fix this mistakes. Thanks! P.S. Please, change component from UI to WikiText. *** Bug 298687 has been marked as a duplicate of this bug. *** In General > Editors > Text Editor I have an almost black as my background, yellow as my foreground and black as my background color. This is how I like to edit my code. In the Mylyn task editor, none of those values are used for the text. I get a white background with a black foreground (note that none of those are from my settings). For the current line, the task editor DOES use the general setting for the highlight, but not for the foreground and background. Therefore I get unreadable text. In my opinion, Mylyn should provide its own text editor settings for colors, like the C++ mode does. Otherwise, use all of the general settings or none of them. By using a portion of the general settings the user can get unreadable text. This is often a problem with people that want to use black backgrounds. I don't feel a user should change their settings for editing my code to satisfy Mylyn's editor. Since this issue results in unreadable text in Mylyn's default configuration for users with black text backgrounds, I think it should be reclassified as Minor instead of an enhancement. At least to fix the bug Mylyn could be changed to not highlight the current line. That would be a smaller change than supporting full customization. Highlighting of the current line is a WikiText feature. As a work-around you can set the repository to use Plain text mode in the repository settings under Task Editor Settings. David, would it be feasible to generally disable highlighting of the current line when WikiText is embedded in the task editor? I haven't seen other form based editors that do that and it is slightly inconsistent with the plain text mode. (In reply to comment #14) > Highlighting of the current line is a WikiText feature. As a work-around you can > set the repository to use Plain text mode in the repository settings under Task > Editor Settings. Current line highlight is controlled by an Eclipse preference under *Preferences -> General -> Editors -> Text Editors -> Highlight Current Line*. > David, would it be feasible to generally disable highlighting of the current > line when WikiText is embedded in the task editor? Yes (see preference above) > I haven't seen other form based editors that do that and it is slightly inconsistent with the plain text > mode. It's the same as all text editors in Eclipse. I'm open to discussion on this issue, however the issue may be moot since a preference is already available to control it. Sorry David, I don't think you understand the issue. This is a problem for a user that uses a black background and wants to highlight their current line during their code editing. In Mylyn this results in unreadable text by default. Your solution is to disable highlighting of the current line for ALL modes. Thus, you are asking the user to change their editor for the majority of their work (editing code) for Mylyn. Again, if Mylyn would either follow ALL the text editor settings (background, foreground, highlighted line, etc.) or NONE of them (just force black text on a white background), then users would not need to modify their other editing modes. I'm sorry if I'm not being clear, please let me know if you have additional questions. Eric, thanks for the clarification! Sorry for not posting here: see bug 299697 where a separate preference is implemented for the task editor. Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn |