Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 256926

Summary:	[About] About dialog does not change about.mappings for dynamic product
Product:	[Eclipse Project] Platform	Reporter:	Kim Horne <eclipse>
Component:	UI	Assignee:	Kim Horne <eclipse>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	pwebster, raji
Version:	3.4	Flags:	pwebster: review+
Target Milestone:	3.4.2
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:	237273
Bug Blocks:

Description Kim Horne

2008-11-28 12:57:32 EST

+++ This bug was initially created as a clone of Bug #237273 +++

Build ID: I20080613-2000

Steps To Reproduce:
Our rcp application has an IProductProvider to create IProduct dynamically. In our product, IProduct.getDefiningBundle() returns different result per window. 

Problem:
Once about.mapping is loaded, that mapping is always used, and never updated, even if IProdut.getDefiningBundle() returns a different bundle later.

Comment 1 Kim Horne

2008-11-28 12:58:01 EST

Paul, could I get a +1 on the patch from the dependent bug?

Comment 2 Kim Horne

2008-11-28 13:22:22 EST

Adding Paul.

Comment 3 Paul Webster

2008-11-28 13:51:32 EST

Assuming that this simply tracks mappings (and not system properties) by bundle if Bug 256924 is applied and that it's used in "String[] tempMappings = (String[])mappings.clone();" as well, this is probably fine.

I'll just point out that line 309 "Bundle definingBundle = product.getDefiningBundle();" (without bug 256924 applied) should probably be moved above line 297

PW

Comment 4 Kim Horne

2008-11-28 14:02:11 EST

(In reply to comment #3)
> Assuming that this simply tracks mappings (and not system properties) by bundle
> if Bug 256924 is applied and that it's used in "String[] tempMappings =
> (String[])mappings.clone();" as well, this is probably fine.
> 
> I'll just point out that line 309 "Bundle definingBundle =
> product.getDefiningBundle();" (without bug 256924 applied) should probably be
> moved above line 297
> 
> PW
> 

Reconciling these patches was a pain.  I will make the branch match v1.13 - the result of applying this patch to HEAD and the latest iteration of this class.

Comment 5 Paul Webster

2009-01-22 13:59:51 EST

In M20090121-1700
PW