Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 256921

Summary:

Wrong type used in org.eclipse.help

Product:

[Eclipse Project] Platform

Reporter:

Olivier Thomann <Olivier_Thomann>

Component:

User Assistance

Assignee:

Chris Goldthorpe <cgold>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

cgold

Version:

3.5

Target Milestone:

3.5 M5

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Olivier Thomann

2008-11-28 12:44:17 EST

That bundle is supposed to be Foundation 1.0 compliant according to the 3.4
plan. Maybe this has changed for 3.5.
The EEs defined for this project are:
Bundle-RequiredExecutionEnvironment: J2SE-1.4,
 CDC-1.0/Foundation-1.0,
 J2SE-1.3

And for the compilation, pde.build ends up taking the first execution
environment which is 1.4. If pde.build would take the latest execution
environment, it would not compile.

The bundle execution environment should be changed to 1.4 or some type
references and method calls should be removed.

Here is the list of possible problematic references found by the new validation
from api tooling:

The type java.util.LinkedHashSet referenced in org.eclipse.help.internal.util.ProductPreferences.getOrderedList(List, List, List[], Map) is not defined in bundle's required execution environment: J2SE-1.3
The constructor LinkedHashSet(Collection) referenced in org.eclipse.help.internal.util.ProductPreferences.getOrderedList(List, List, List[], Map) is not defined in bundle's required execution environment: J2SE-1.3

Note that LinkedHashSet is also not defined for Foundation 1.0.

Comment 1 Chris Goldthorpe

2008-12-01 18:11:45 EST

I'll wait to see how the Foundation 1.0 debate plays out but one way or another I'll fix this for Eclipse 3.5.

Comment 2 Chris Goldthorpe

2008-12-12 17:54:12 EST

Created attachment 120382 [details]
Patch

This is the code which sorts the books in the toc. The number of books is small compared to the number of topics and a List will work in place of the LinkedHashSet (which is an order preserving collection).

Comment 3 Chris Goldthorpe

2008-12-12 17:56:10 EST

Patch applied, fixed.

Comment 4 Chris Goldthorpe

2009-03-27 19:21:29 EDT

*** Bug 255822 has been marked as a duplicate of this bug. ***