Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 256805

Summary:	SaveablesCompareEditorInput polishing
Product:	[Eclipse Project] Platform	Reporter:	Tomasz Zarna <tomasz.zarna>
Component:	Team	Assignee:	Platform Team Inbox <platform-team-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	pawel.pogorzelski1
Version:	3.5
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:	stalebug
Bug Depends on:
Bug Blocks:	207939

Description Tomasz Zarna

2008-11-27 11:26:51 EST

Some code from SaveablesCompareEditorInput actually duplicates the code that was already in SaveableCompareEditorInput (without s), we could either move the code to a shared, abstract superclass, or make the SaveablesCompareEditorInput the superclass. The later would make SaveableCompareEditorInput (without s) a special case of Saveables* where there is only when saveable element. Let's leave it to Szymon to decide how to handle it.

Comment 1 Tomasz Zarna

2008-11-28 10:12:37 EST

The other thing we could consider here is moving the new SaveablesCompareEditorInput[1] class to Compare. This would allow us to replace currently existing there ResourceCompareInput[2], which generally does the same thing. At the same time we would get rid of two ComapreActions[3][4] (one in Compare, one in Team/UI) and the situation when one overrides the other.

[1] org.eclipse.team.internal.ui.synchronize.SaveablesCompareEditorInput
[2] org.eclipse.compare.internal.ResourceCompareInput
[3] org.eclipse.compare.internal.CompareAction
[4] org.eclipse.team.internal.ui.actions.CompareAction

Comment 2 Pawel Pogorzelski

2009-01-14 10:49:06 EST

(In reply to comment #1)
> The other thing we could consider here is moving the new
> SaveablesCompareEditorInput[1] class to Compare. This would allow us to replace
> currently existing there ResourceCompareInput[2], which generally does the same
> thing. 

Such a move will enable proper behaviour of the "Change encoding" action without Team component present. The action was introduced in bug 223857 and it fails on assertion without Team present.

Steps:
1. Go to Window > Preferences > General > Capabilities and disable Team
2. Restart Eclipse
3. Select two resources from workspace
4. Open them in a compare editor
5. Select "Set encoding..."

Result:
6. AssertionFailedException in the error log

Comment 3 Szymon Brandys

2015-04-01 09:44:32 EDT

I am no longer involved in Platform Team/Compare development.

Comment 4 Eclipse Genie

2020-01-31 03:27:13 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.