Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 256357

Summary: Upgrade all EMF-based models in DTP core components
Product: [Tools] Data Tools Reporter: Linda Chan <lchan>
Component: DataToolsAssignee: Hemant Kolwalkar <hskolwal>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: bfitzpat, hskolwal, hui.cao, hung.hsi, linsong
Version: GanymedeKeywords: plan
Target Milestone: 1.7RC1   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Attachments:
Description Flags
update ASA emf model
none
Patch - upgrade ODA design model to EMF 2.4.x none

Description Linda Chan CLA 2008-11-24 18:28:54 EST
The current EMF-based models in DTP components were last generated with EMF 2.2.2 in order to support JDK 1.4.2.
DTP is now upgraded to build with JDK 1.5 and EMF 2.4.1 for the Galileo release.
All the EMF-based models in DTP (including Query Model, SQL Query Model, ODA Design Model) should be upgraded in Galileo and re-generate using EMF 2.4.x.  

Such upgrades will need to provide backward compatibility handling of those model objects that were persisted using older DTP releases.
Comment 1 Brian Fitzpatrick CLA 2009-04-09 12:11:58 EDT
Hey Hemant... Did this ever happen? I'm guessing so and we just need to close it...
Comment 2 Hemant Kolwalkar CLA 2009-04-13 13:44:26 EDT
let me double check on the Query Model, SQL Query Model, ODA Design Model and get back.
Comment 3 Hemant Kolwalkar CLA 2009-04-23 13:11:52 EDT
Hi Brian,

i checked all ecore models and all of them seem upto date except for below.

could you and Linda check if the models in the following plugins are at Eclipse3.4/EMF 2.4 level.

org.eclipse.datatools.connectivity.oda.design

i see a lot of difference in generated code if i use the ecore file as source as compared to the code in CVS.

org.eclipse.datatools.enablement.sybase.asa.models

i got some errors related to default values when i tried to reload the genmodel. the errors did not pinpoint where in the model the offending default values were defined.
Comment 4 Brian Fitzpatrick CLA 2009-04-23 13:41:56 EDT
Max or Samuel, can you take a look at the ASA model to see what's going on and why it's not regenerating properly? We need to get all the models regenerated with 2.4.1 to better support the Galileo release.
Comment 5 Hung Hsi CLA 2009-04-23 15:45:39 EDT
Samuel, please look into this asap. Thanks.
Comment 6 song lin CLA 2009-04-23 22:24:47 EDT
Created attachment 133044 [details]
update ASA emf model

Remove useless 'defaultValueLiteral=""' to avoid emf genmodel error.
Comment 7 Linda Chan CLA 2009-04-23 23:33:40 EDT
Created attachment 133054 [details]
Patch - upgrade ODA design model to EMF 2.4.x

Committed patch of oda.design plugin, whose source are re-generated with EMF 2.4.1 and JDK compliance level 5.0.  Applied tag v200904241122.
Comment 8 song lin CLA 2009-04-24 03:23:46 EDT
(In reply to comment #6)
> Created an attachment (id=133044) [details]
> update ASA emf model
> 
> Remove useless 'defaultValueLiteral=""' to avoid emf genmodel error.
> 

Delivered.
Tag v200904240306
Comment 9 Brian Fitzpatrick CLA 2009-04-24 11:49:50 EDT
Hemant, can you take a look again to see if this has been resolved?
Comment 10 Hemant Kolwalkar CLA 2009-04-26 03:27:09 EDT
yes. though i have a question for Linda. the DesignXML.xsd under model folder in the oda.design plugin does not seem to be the source for the oda.design.ecore model. 

because if i used DesignXML.xsd to reload the genmodel and regenerate the ecore and code, i see a whole lot of differences. that was what i had observed.

i defer this to Linda to make the call on this as she is more informed about the model then i am.
Comment 11 Linda Chan CLA 2009-04-27 15:02:59 EDT
I'd used odaDesignSession.genmodel as the base to re-generate the source.  The DesignXML.xsd is also generated/exported from genmodel.
I have now also added its model files in the binary build.
Comment 12 Brian Fitzpatrick CLA 2009-04-30 15:36:24 EDT
Can we consider this done?
Comment 13 Hung Hsi CLA 2009-04-30 15:40:28 EDT
Assigned to Kamal to confirm whether the tasks (from Linda and Song Lin) are considered done.
Comment 14 Hung Hsi CLA 2009-05-08 22:24:17 EDT
1.7M7 is already in test stage, moved to 1.7RC1 for now. 
Please confirm if it's considered done. Thanks.
Comment 15 Brian Fitzpatrick CLA 2009-05-26 11:18:59 EDT
Hemant? Is this already to be considered done?
Comment 16 Brian Fitzpatrick CLA 2009-06-01 09:46:43 EDT
Since I have heard nothing from anyone about this, I'm going to consider this fixed.
Comment 17 Hemant Kolwalkar CLA 2009-06-01 13:02:28 EDT
sorry, Brian. had meant to reply last week but got distracted. yes, after the taks done by  Linda, Song Lin, we can consider this done.