Bugzilla – Full Text Bug Listing
| Summary: | Probe Profiling fails in the External Java Application use case | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Raheel Ashraf <rashraf> | ||||||
| Component: | TPTP | Assignee: | Raheel Ashraf <rashraf> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P1 | CC: | jgwest, jkubasta, paulslau | ||||||
| Version: | unspecified | Flags: | paulslau:
review+
|
||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | closed460 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 228731 | ||||||||
| Attachments: |
|
||||||||
|
Description
Raheel Ashraf
Here are the details: This is because the code in ProbekitLaunchUtil does add bootclasspath to the launch arguments but its only designed to work for the local launch scenario and it doesnt work for the remote case.. Created attachment 118295 [details]
patch
Reviewed with comments: -Ensure the copyright year is correct. -Add //$NON-NLS-1$ at the end of each line that contains a untranslated string or <right click Java file in Package Explorer> >> Source >> Externalize Strings. -Only have one conditional block with OS-specific code and check if there is a OS flag/constant somewhere else in the plug-in that you can use. -Will this patch resolve the case where the Foo class is not on the AC's classpath? Jonathan: Can you review the attached patch as well? Created attachment 118368 [details] patch Thanks Paul for the review. I have updated the patch. >>Ensure the copyright year is correct. it was already 2008 >>Add //$NON-NLS-1$ at the end of each line that contains a untranslated string or <right click Java file in Package Explorer> >> Source >> Externalize Strings. done >>Only have one conditional block with OS-specific code and check if there is a OS flag/constant somewhere else in the plug-in that you can use. used only one conditional block. No constant found elsewhere. In other places, this is done in similar fashion >>Will this patch resolve the case where the Foo class is not on the AC's classpath? Not sure what is meant but this patch will solve the stated problem in the bug desc. (In reply to comment #4) Looks great, thanks. > >>Will this patch resolve the case where the Foo class is not on the AC's > classpath? > > Not sure what is meant but this patch will solve the stated problem in the bug > desc. I was thinking that the value for the boot classpath was coming from the AC's classpath (that is, the JVMTI application configured in the AC) but it is in fact coming from the classpath for the profile launch configuration. My mistake. Is Jonathan's review still required? (In reply to comment #6) > Is Jonathan's review still required? > No, given comment #5. patch committed to head As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |