Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 255553

Summary: Compartments should support line styles by default
Product: [Modeling] GMF-Runtime Reporter: Lidija Grahek <lgrahek>
Component: GeneralAssignee: Lidija Grahek <lgrahek>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse
Version: 2.1   
Target Milestone: 2.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 255554    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch ahunter.eclipse: iplog+

Description Lidija Grahek CLA 2008-11-17 13:52:48 EST
Created attachment 118081 [details]
Patch

Line type style was added to GMF 2.1 but only geoshapes, notes and lines support it. We need to add the support to compartments in GMF.

Attached patch contains adds this functionality. Note: GeoShapeLineStyleBorder can probably be depricated now that its parent LineBorder has style field. LineBorder could be used instead.
Comment 1 Lidija Grahek CLA 2008-12-10 11:18:54 EST
Note: Patch for 255554 LineBorder should support line style has to be committed to GEF before this patch.
Comment 2 Anthony Hunter CLA 2008-12-10 16:57:52 EST
Can you refresh this patch for me?

ShadowRectangleEditPart and RectangularDropShadowLineBorder have changed since you created the patch.

There also should be no org.eclipse.draw2d.LineBorder in the GMF patch.
Comment 3 Lidija Grahek CLA 2008-12-11 17:05:43 EST
Created attachment 120259 [details]
Patch

Refreshed patch as requested in comment #2
Comment 4 Anthony Hunter CLA 2008-12-11 19:40:04 EST
Committed to HEAD
Comment 5 Eclipse Webmaster CLA 2010-07-16 23:36:10 EDT
[target cleanup] 2.2 M4 was the original target milestone for this
bug
Comment 6 Eclipse Webmaster CLA 2010-07-19 21:59:20 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug