Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 255450

Summary:

Wrong javadoc @See tag at GraphViewer constructor

Product:

[Tools] GEF

Reporter:

kiril mitov <thebravoman>

Component:

GEF-Legacy Zest

Assignee:

Alexander Nyßen <nyssen>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

nyssen

Version:

3.4

Target Milestone:

3.10.0 (Mars) M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Removing wrong javadoc	none

Description kiril mitov

2008-11-16 04:21:27 EST

The constructor of GraphViewer is documented as:
/**
	 * Initializes the viewer.
	 * 
	 * @param composite
	 * @param style
	 *            the style for the viewer and for the layout algorithm
	 * @see ZestStyles#LAYOUT_GRID
	 * @see ZestStyles#LAYOUT_TREE
	 * @see ZestStyles#LAYOUT_RADIAL
	 * @see ZestStyles#LAYOUT_SPRING
	 * @see ZestStyles#NO_OVERLAPPING_NODES
	 * @see ZestStyles#NODES_HIGHLIGHT_ADJACENT
	 * @see SWT#V_SCROLL
	 * @see SWT#H_SCROLL
	 */

But in ZestStyles there are no LAYOUT_* constants.

Comment 1 kiril mitov

2008-11-16 04:28:47 EST

Created attachment 117992 [details]
Removing wrong javadoc

The patch is removing the ZestStyles#LAYOUT*, ZestStyles#NODES_HIGHLIGHT_ADJACENT,ZestStyles#NO_OVERLAPPING_NODES.
I have checked that only ZestStyles#IGNORE_INVISIBLE_LAYOUT is used and I am adding it to the javadoc of the constructor.

Comment 2 Alexander Nyßen

2014-08-10 17:32:45 EDT

Fixed javadoc of constructor to not list the ZestStyles that are not evaluated. Pushed changes to origin/master. Resolving as fixed in 3.10.0M1.