Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 254921

Summary: PopupBarTool should call getTargetEditPart(Request) to find
Product: [Modeling] GMF-Runtime Reporter: Michael Golubev <borlander>
Component: GeneralAssignee: Anthony Hunter <ahunter.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse, tatiana.fesenko, tikhomirov.artem
Version: unspecified   
Target Milestone: 2.2   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Bug Depends on:    
Bug Blocks: 254908    
Attachments:
Description Flags
Hopefully fixes the subj none

Description Michael Golubev CLA 2008-11-11 12:42:13 EST 
This is side effect of the change described in the bug #250271.

After #250271 is fixed, the top-level editpart (like Class editpart) now delegates some of creation requests to its compartments via getTargetEditPart() method. 

It works perfectly for default creation tools (from palette), but does not work well for popup bar (see, e.g. U2T specific bug #254908 for user visible issue on U2T class diagram).

To fully emulate the creation tools behavior, PopupBarTool should respect the possibility that creation request may be redirected from host to some other edit part by host's getTargetEditPart(request) method.
Comment 1 Michael Golubev CLA 2008-11-11 12:45:39 EST 
Created attachment 117570 [details]
Hopefully fixes the subj
Comment 2 Artem Tikhomirov CLA 2008-12-15 13:18:36 EST 
Any chances to get this one fixed by M4? Now popup bars don't work for children in compartments, and though we can workaround that with extra code inside Creation EditPolicy, using getTargetEditPart() from PopupBarTool to find out proper command source seems to be the right approach (honest GEF way).
Comment 3 Anthony Hunter CLA 2008-12-17 14:27:53 EST 
(In reply to comment #2)
> Any chances to get this one fixed by M4? [...]

Yes, the change looks ok, will do.
Comment 4 Anthony Hunter CLA 2008-12-18 10:38:58 EST 
Committed to HEAD for 2.2 M4
Comment 5 Eclipse Webmaster CLA 2010-07-16 23:36:00 EDT 
[target cleanup] 2.2 M4 was the original target milestone for this
bug
Comment 6 Eclipse Webmaster CLA 2010-07-19 12:26:58 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug