Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 254614

Summary: Promptable filter's shouldn't require supportsCommands on the subsystem to be false
Product: [Tools] Target Management Reporter: Kevin Doyle <kjdoyle>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: kjdoyle, rdibugs
Version: 3.0.1   
Target Milestone: 3.1 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 254641    
Attachments:
Description Flags
patch to not use supportsCommands() when determining whether to prompt none

Description Kevin Doyle CLA 2008-11-07 11:51:59 EST 
In SystemViewFilterReferenceAdapter.internalGetChildren we made a change that a promptable filter wasn't promptable unless !ssf.supportsCommands() was true as well as the promptable flag on the filter.  With some additional changes that have been made on our side and rse this is no longer needed and should be changed back to just checking if promptable flag is true, as it shouldn't depend on supports commands.
Comment 1 David McKnight CLA 2008-11-07 12:29:35 EST 
Kevin, just to clarify, does this defect have any bearing on bug 254605 and/or bug 249245?  Is supportsCommands() still needed for determining when to show the Go Into and Show In Table actions?
Comment 2 Kevin Doyle CLA 2008-11-07 13:14:19 EST 
(In reply to comment #1)
> Kevin, just to clarify, does this defect have any bearing on bug 254605 and/or
> bug 249245?  Is supportsCommands() still needed for determining when to show
> the Go Into and Show In Table actions?

Nope.  Those still need to be the way they are.
Comment 3 David McKnight CLA 2008-11-07 13:51:37 EST 
Created attachment 117349 [details]
patch to not use supportsCommands() when determining whether to prompt

Kevin, does this patch resolve this?
Comment 4 Kevin Doyle CLA 2008-11-07 13:55:02 EST 
Yes, that fixes the issue.  We need this backported as well.
Comment 5 David McKnight CLA 2008-11-07 14:19:23 EST 
I've committed this to cvs and opened backport bug 254641.