Bugzilla – Full Text Bug Listing
| Summary: | [Help] For Eclipse 3.4.2 fix regression caused by fix for Bug 237326 - [Help][Context] F1 accessibility - no indication that help view has opened (since there is no focus change) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Chris Goldthorpe <cgold> | ||||||
| Component: | UI | Assignee: | Eric Moffatt <emoffatt> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | blocker | ||||||||
| Priority: | P1 | CC: | bokowski, cgold, edwinc, Kevin_McGuire, Mike_Wilson | ||||||
| Version: | 3.4.1 | Flags: | Mike_Wilson:
pmc_approved+
emoffatt: review+ |
||||||
| Target Milestone: | 3.4.2 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Chris Goldthorpe
The more I think about this the less sure I am that backing out the fix for Bug 237326 is the right way to go. Bug 237326 fixed a serious problem for users who used screenreaders, the fix for this bug caused the properties view to get temporarily out of synch whith the editor after F1 was pressed. I'm wondering why this problem was identified as a blocker, no data is lost, there is no crash and the user will quickly figure out how to restore the contents of the properties view. It seems to me that Bug 237326 was a major problem for a minority of users, this is a less severe problem but affects more users. While I had previously supported backing out this fix I'm now thinking that that was an important bug fix for users with visual impairment and the right thing to do would be to try to fix both problems rather than fixing one bug by reintroducing another. Created attachment 117247 [details]
Exclude the HelpView from participation in the PropertySheet
Warning: This fix is -not- a general solution because it uses the help view's id in a non safe manner. This should be OK for the maintenance stream bet a more general solution should be devised for the 3.5 stream.
Changed title to [Help] For Eclipse 3.4.2 fix regression caused by fix for Bug 237326 - [Help][Context] F1 accessibility - no indication that help view has opened (since there is no focus change) and reassigned to Eric Moffatt. Setting approval flags... I'll get Boris to look at the patch while we review another one we're working on. I looked at the patch with Eric, this is just to capture what we talked about: - The bundle version (MANIFEST.MF) needs to be updated to 3.3.1. - Put the bug number in the comment. - Reverse the .equals logic to guards against potential null value of getId. Created attachment 117485 [details]
Revised patch containing Boris' suggestions
Also branched org.eclipse.ui.views ('R3_4_maintenance') to capture the change.
+'ing on Boris' behalf (as per our review). Committed in >20081110. Applied the second patch. Committed in >20081117. Branched R3_4_1_maintenance_patches off of the R3_4_1 version. Applied the patch. Please let me know if there's anything else I should be doing... You need to run the release tool on the maintenance_patches stream if you have not already done so. Done...thanks for the heads up I've used "M20081117-for253977" as the tag... Verified in M20090121-1700. |