Bug 253635

Description Simon Archer 2008-11-04 00:06:46 EST

Using Eclipse 3.5M3

While bug 248816 addresses the automatic population of the wizard's "Name" field, there are some other issues with the wizard that need addressing:

1.  The dialog has no title.

2.  While I realize that this dialog follows the convention of many other
    PDE dialogs, the organization of this dialog looks too busy. I'd rather
    see the part where you pick a parent folder on a page on its own.
    Putting all these UI elements on one page feels cramped and confusing.

3.  While I hate to re-implement behavior that is available else where, I
    feel that there needs to be a way to create a folder.  This behavior
    should also reside on the first page of the wizard, since it's part of
    picking a parent. I'd really like to find a way to encourage people to
    put their XML documents in a common place, such as OSGI-INF, otherwise
    they're all going to end up in the root of the project, which I'm never
    a fan of.  But, even if we give the user the opportunity to create a
    folder, that does not mean that they'll pick OSGI-INF, so we need to
    come up with something clever to make that the default choice.

4.  I'd like to see the "File name:" field and the "Component Definition
    Information" moved on to a separate page. Today, the "File name:" field
    looks strange since it's stuck between the "pick a parent" composite and
    the group control. Separating these concerns will possibly improve
    usability.

5.  The "File name:" field needs to be automatically populated, and I
    suggest that we use "component.xml".  In most cases there will only
    be a single XML document, so this name works perfectly. The value of
    this field should be persisted (using either dialog settings or plug-in 
    preferences) so that the user does not have to enter their preferred
    name every time.

6.  Today you can enter a name in the "Class:" field, or using the
    "Browse..." button you can pick an existing class, but I typically find
    that neither of these are helpful. What I typically want to do is
    generate a class, so that means that I want to pick a parent package and
    enter the name of the class and have it generated for me by the wizard. 
    Again, I hate to ask for behavior that is already implemented elsewhere,
    such as in JDT, so maybe there's a way to launch the "New Java Class"
    wizard here.

7.  Clicking the "Browse..." button allows you to pick any class in the
    workspace, when really you should only be picking a class visible to the
    defining bundle, namely: Any class that is defined by the bundle, or any
    class visible to the bundle per its Import-Package and Require-Bundle
    manifest headers.

8.  The error message "Names cannot be empty." is not particularly helpful,
    plus, once you've entered something in the "Field name:" and "Name:"
    field there is no error message telling you to populate the "Class:"
    field, and the "Finish" button remains disabled. We also need some
    improvements to the field validation, since entering nonsense values,
    such as spaces seems to satisfy the field validation.

9.  The wizard updates the bundle's Service-Component header, but it does
    not do any validation: For example, it should check to see if the value
    that it is appending to the header already exists, since today if you 
    create a component XML document, delete it, and then recreate it, you
    end up with the XML document appearing twice. Also see bug 249391.

10. The "Name:" field, the "Class:" field and the "Browse..." button do not
    have ALT accelerators.