Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 253142

Summary: [api] provide scrollbar to task repository properties page
Product: z_Archived Reporter: Steffen Pingel <steffen.pingel>
Component: MylynAssignee: Frank Becker <eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: greensopinion, sam.davis
Version: unspecifiedKeywords: plan
Target Milestone: 3.9   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 240554, 376840    
Bug Blocks:    
Attachments:
Description Flags
mylyn/context/zip
none
mylyn/context/zip none

Description Steffen Pingel CLA 2008-11-03 03:14:36 EST 
The task repository properties dialog gets very tall when many of the sections on the page are expanded. On small displays the dialog may not even display all elements. It would be useful if the dialog provided vertical scroll bar when needed.

An example in platform is org.eclipse.jdt.internal.ui.preferences.OptionsConfigurationBlock which leverages the forms API to provide scrolling in preference pages. A shared form toolkit that is available to all dialogs is used to manage focus and key listeners. A similar approach could work well for the task repository page but the API has to be designed carefully to maintain backwards compatibility.
Comment 1 Steffen Pingel CLA 2012-09-09 21:20:17 EDT 
Frank, I'll assign this to you since it's essentially the change that is proposed on bug 376840.
Comment 2 Frank Becker CLA 2012-10-08 11:13:15 EDT 
Create review https://git.eclipse.org/r/8085.
This is an update of the review https://git.eclipse.org/r/6038 but I must change two fields and two methods from private to protected in AbstractTaskRepositoryPage. All other changes are only in AbstractRepositorySettingPage. For more details look into the comments of https://git.eclipse.org/r/6038.
Comment 3 Frank Becker CLA 2012-10-08 11:13:19 EDT 
Created attachment 222024 [details]
mylyn/context/zip
Comment 4 Frank Becker CLA 2012-10-19 13:48:01 EDT 
patch set 2 in now in the review!
Comment 5 Frank Becker CLA 2012-10-19 13:48:06 EDT 
Created attachment 222592 [details]
mylyn/context/zip
Comment 6 Steffen Pingel CLA 2012-10-29 17:40:44 EDT 
I have pushed a simplified version: https://git.eclipse.org/r/#/c/8085/4 . Frank, please let me know if that works for you and if not if there is anything we could change in SectionComposite to make it work.
Comment 7 Frank Becker CLA 2012-10-29 23:42:36 EDT 
(In reply to comment #6)
> I have pushed a simplified version: https://git.eclipse.org/r/#/c/8085/4 .
> Frank, please let me know if that works for you and if not if there is anything
> we could change in SectionComposite to make it work.

works!!!

How do we continue?
Comment 8 Steffen Pingel CLA 2012-10-30 04:49:48 EDT 
I submitted the change. Thanks for all your efforts here!
Comment 9 Frank Becker CLA 2012-11-19 15:26:59 EST 
I fixed the regression "validate on finish" button not visible (bug#379619 comment#23) and commit the patch to master.