Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 252959

Summary: Delete and Select All context and file menus are missing.
Product: z_Archived Reporter: Paul Slauenwhite <paulslau>
Component: TPTPAssignee: Paul Slauenwhite <paulslau>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: alexberns, paulslau
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: adopter
Bug Depends on: 173653, 256807    
Bug Blocks: 293690, 307782    
Attachments:
Description Flags
Patch. none

Description Paul Slauenwhite CLA 2008-10-31 08:27:59 EDT 
Delete and Select All context and file menus are missing.

Support the 'Delete (Delete)' and 'Select All (Ctrl+A)' menus on the datapool table context menu and Edit menu.  The Delete key is currently supported, however, support for Ctrl-A is required. 

This defect requires a new test case.
Comment 1 Paul Slauenwhite CLA 2008-10-31 08:37:18 EDT 
Also, support the 'Find/Replace... (Ctrl+F)' menu on the datapool table context menu.
Comment 2 Paul Slauenwhite CLA 2008-11-26 07:23:16 EST 
Deferring to TPTP 4.3 since this defect requires new strings (text (or label) and description) for the Find/Replace (see org.eclipse.hyades.test.ui.datapool.internal.control.DatapoolActionHandlerListener.connectFindReplaceAction(IWorkbenchPart)),
Select All, and Delete actions, which require translation.  

In addition, the copy action (/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/datapool/internal/action/CopyAction.java) requires a new string for the description.
Comment 3 Paul Slauenwhite CLA 2008-11-27 17:03:09 EST 
Also, support the 'Revert' menu on the datapool table context menu.
Comment 4 Paul Slauenwhite CLA 2009-07-16 10:52:02 EDT 
Requires changes to
/org.eclipse.hyades.test.doc.user/concepts/cdatapooleditor.htm to reflect the
support added by this defect.
Comment 5 Paul Slauenwhite CLA 2009-07-16 11:10:21 EDT 
Also, delete variable shortcut (right-click on the datapool table and select Ctrl+Insert - see org.eclipse.hyades.test.doc.user/concepts/cdatapooleditor.htm) does not guard against removing all variables.
Comment 6 Paul Slauenwhite CLA 2010-03-17 10:22:01 EDT 
The 'Find/Replace... (Ctrl+F)' context/file menus were added under defect 173653.
Comment 7 Paul Slauenwhite CLA 2010-03-17 10:39:28 EDT 
(In reply to comment #3)
> Also, support the 'Revert' menu on the datapool table context menu.

Not required since the Revert file menu is working as designed (see 256807) and the 'File' file menus (for example, Save, Save As, etc.) are not display in the datapool table context menu.  However, we will deliver a test case for the Revert file menu under this defect.
Comment 8 Paul Slauenwhite CLA 2010-03-30 10:18:26 EDT 
(In reply to comment #5)
> Also, delete variable shortcut (right-click on the datapool table and select
> Ctrl+Insert - see
> org.eclipse.hyades.test.doc.user/concepts/cdatapooleditor.htm) does not guard
> against removing all variables.

That is, Ctrl + Delete.
Comment 9 Paul Slauenwhite CLA 2010-03-30 11:15:41 EDT 
Created attachment 163414 [details]
Patch.
Comment 10 Paul Slauenwhite CLA 2010-03-30 11:17:03 EDT 
Added two new test cases and refactored four existing test cases in /org.eclipse.hyades.test.ui.datapool.tests/manual/datapool/Test.UI.DatapoolEditor_editing.testsuite to cover these symptoms.

Updated the Datapool Editor documentation.

The attached patch is checked in to CVS (HEAD).
Comment 11 Paul Slauenwhite CLA 2010-06-23 12:29:38 EDT 
Verified in TPTP-4.7.0RC4-201006081927.

Closing.