Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 252329

Summary: Externalize Strings Wizard does not show un-externalized names of extension(-point)
Product: [Eclipse Project] PDE Reporter: Matthias Gradl <matthias.gradl>
Component: UIAssignee: Chris Aniszczyk <caniszczyk>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: caniszczyk, contact, sja.eclipse
Version: 3.4.1   
Target Milestone: 3.5 M4   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Attachments:
Description Flags
Patch
caniszczyk: iplog+
Patch
none
mylyn/context/zip none

Description Matthias Gradl CLA 2008-10-28 06:58:54 EDT
I was checking for un-externalized Strings in my plug-in and therefore enabled the compiler check in the PDE to report them.

My plugin contained 3 of them which were properly shown in the problems view. Using the externalize wizard link from the overview page only shows the message that already all strings have been externalized. With the quick fix for the problem which offers me to externalize the single entry, all entries can be externalized properly. The wizard starting from the quick fix doesn't work either.

So, I suppose the wizard does not recognize all translatable strings, but the compiler seems to find more of them.


Example plugin.xml to reproduce:
<?xml version="1.0" encoding="UTF-8"?>
<?eclipse version="3.2"?>
<plugin>
   <extension-point id="id2" name="name2" schema="schema/id2.exsd"/>
   <extension-point id="id1" name="name1" schema="schema/id1.exsd"/>
   <extension
         id="marker1"
         name="markerName1"
         point="org.eclipse.core.resources.markers">
   </extension>
</plugin>
Comment 1 Benjamin Cabé CLA 2008-10-30 18:01:28 EDT
Created attachment 116570 [details]
Patch

Here is a patch against GetNonExternalizedStringsOperation to analyse <extension> and <extension-point> nodes and not only children <extension>s nodes
Comment 2 Benjamin Cabé CLA 2008-10-30 18:01:28 EDT
Created attachment 116571 [details]
Patch

Here is a patch against GetNonExternalizedStringsOperation to analyse <extension> and <extension-point> nodes and not only children <extension>s nodes
Comment 3 Benjamin Cabé CLA 2008-10-30 18:05:27 EDT
Comment on attachment 116571 [details]
Patch

mylyn+bugzilla lag=kaboom!
Comment 4 Benjamin Cabé CLA 2008-10-30 18:05:46 EDT
Created attachment 116572 [details]
mylyn/context/zip
Comment 5 Chris Aniszczyk CLA 2008-11-03 16:14:08 EST
done.

> 20091103

Thanks Ben!
Comment 6 Chris Aniszczyk CLA 2008-11-04 17:58:18 EST
*** Bug 246788 has been marked as a duplicate of this bug. ***