Bugzilla – Full Text Bug Listing
| Summary: | Update the WSDL validator to use WSDL4J 1.5.1 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Webservices | Reporter: | Valentin Baciu <valentinbaciu> | ||||||
| Component: | wst.wsdl | Assignee: | Amy Wu <for.work.things> | ||||||
| Status: | CLOSED FIXED | QA Contact: | Valentin Baciu <valentinbaciu> | ||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | Keywords: | plan | ||||||
| Version: | 3.1 | ||||||||
| Target Milestone: | 3.1 M5 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 197197, 235821 | ||||||||
| Attachments: |
|
||||||||
|
Description
Valentin Baciu
Upgrading org.eclipse.wst.wsdl.validation (and org.eclipse.wst.wsdl.validation.tests) to use WSDL4J 1.5.1 has been going fine thus far. Here are the main changes I had to look out for when upgrading - some constants that used to be in com.ibm.wsdl.Constants got moved to com.ibm.wsdl.extensions.schema.SchemaConstants - some methods in DOMUtils now expect a Definition to be passed in as an argument - StringUtils.getContentAsReader() became StringUtils.getContentAsInputStream() - schema elements are no longer of type UnknownExtensibilityElement. they are now of type Schema. The last one was the trickiest to fix since all the other changes were compile errors. I didn't notice the last one until I ran through the unit tests and saw all the failure/errors. I'm now down to 1 junit test failure, and I'm just unsure as to whether the unit test needs to be updated or if there really is a problem to fix. After I get to the bottom of that problem, my next step will be to add some more unit tests that will test for some wsdl 1.5.1 fixes. Created attachment 119400 [details]
org.eclipse.wst.wsdl.validation.txt
Here's a patch with the changes necessary to upgrade the wsdl.validation plugin to use wsdl4j 1.5.x. See my previous comment for changes I made.
Valentin & I talked about increasing the minor version number of the plugin to indicate a major change. I have not done that yet in this patch because this will require changes to other plugins. This patch is just to review/test the upgrade. I can attach another patch with the version number increase and changes to all plugins affected once this patch looks alright.
Created attachment 119401 [details]
org.eclipse.wst.wsdl.validation.tests.txt
Here's the corresponding test plugin patch. In addition to the changes for wsdl4j, I also added 4 new unit tests to test the additional element extensibility support new in jwsdl 1.1.
I've released the fix for this week's wtp 3.1 m5 ibuild. Verified with I-3.1-20090119095149. closing |