Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 252011

Summary: NPE On Promptable Filter's Filter Strings Property Page when Clicking Okay
Product: [Tools] Target Management Reporter: Kevin Doyle <kjdoyle>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: kjdoyle, rdibugs
Version: 3.0.1   
Target Milestone: 3.1 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 253733    
Attachments:
Description Flags
patch to set promptable filter as non-editable none

Description Kevin Doyle CLA 2008-10-24 10:41:37 EDT 
When showing the Filter Strings property page and clicking Okay the following NPE appears.  It looks like we are doing the same processOK checking as if it was not a promptable filter.

!ENTRY org.eclipse.jface 4 0 2008-10-23 12:39:41.484
!MESSAGE java.lang.NullPointerException
!STACK 0
java.lang.NullPointerException
	at org.eclipse.rse.ui.filters.SystemChangeFilterPane.verify(Unknown Source)
	at org.eclipse.rse.ui.filters.SystemChangeFilterPane.processOK(Unknown Source)
	at org.eclipse.rse.ui.propertypages.SystemChangeFilterPropertyPage.performOk(Unknown Source)
	at org.eclipse.jface.preference.PreferenceDialog$13.run(Unknown Source)
	at org.eclipse.core.runtime.SafeRunner.run(Unknown Source)
	at org.eclipse.core.runtime.Platform.run(Unknown Source)
	at org.eclipse.ui.internal.JFaceUtil$1.run(Unknown Source)
	at org.eclipse.jface.util.SafeRunnable.run(Unknown Source)
	at org.eclipse.jface.preference.PreferenceDialog.okPressed(Unknown Source)
	at org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog.okPressed(Unknown Source)
	at org.eclipse.jface.preference.PreferenceDialog.buttonPressed(Unknown Source)
	at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Unknown Source)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(Unknown Source)
	at org.eclipse.swt.widgets.EventTable.sendEvent(Unknown Source)
	at org.eclipse.swt.widgets.Widget.sendEvent(Unknown Source)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Unknown Source)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Unknown Source)
	at org.eclipse.jface.window.Window.runEventLoop(Unknown Source)
	at org.eclipse.jface.window.Window.open(Unknown Source)
	at org.eclipse.ui.dialogs.PropertyDialogAction.run(Unknown Source)
	at org.eclipse.jface.action.Action.runWithEvent(Unknown Source)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(Unknown Source)
	at org.eclipse.jface.action.ActionContributionItem.access$2(Unknown Source)
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(Unknown Source)
	at org.eclipse.swt.widgets.EventTable.sendEvent(Unknown Source)
	at org.eclipse.swt.widgets.Widget.sendEvent(Unknown Source)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Unknown Source)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Unknown Source)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Unknown Source)
	at org.eclipse.ui.internal.Workbench.runUI(Unknown Source)
	at org.eclipse.ui.internal.Workbench.access$4(Unknown Source)
	at org.eclipse.ui.internal.Workbench$5.run(Unknown Source)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Unknown Source)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Unknown Source)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(Unknown Source)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(Unknown Source)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(Unknown Source)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(Unknown Source)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(Unknown Source)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(Unknown Source)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(Unknown Source)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Unknown Source)
	at org.eclipse.equinox.launcher.Main.basicRun(Unknown Source)
	at org.eclipse.equinox.launcher.Main.run(Unknown Source)
	at org.eclipse.equinox.launcher.Main.main(Unknown Source)
Comment 1 David McKnight CLA 2008-10-24 15:20:42 EDT 
Created attachment 116099 [details]
patch to set promptable filter as non-editable
Comment 2 David McKnight CLA 2008-10-24 15:23:29 EDT 
I've committed the patch to cvs.
Comment 3 Kevin Doyle CLA 2008-11-04 11:10:40 EST 
Looks good.  Thanks Dave.  Can we backport?
Comment 4 David McKnight CLA 2008-11-04 11:37:16 EST 
(In reply to comment #3)
> Looks good.  Thanks Dave.  Can we backport?
> 

I've created a bug 253733 to deal with the backport.