Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 251658

Summary: [performance] guard against exceptions during synchronization
Product: z_Archived Reporter: Steffen Pingel <steffen.pingel>
Component: MylynAssignee: Project Inbox <mylyn-triaged>
Status: CLOSED MOVED QA Contact:
Severity: normal    
Priority: P2 CC: jtk499
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Steffen Pingel CLA 2008-10-22 00:30:02 EDT 
If a connector throws an exception synchronization is aborted:

java.lang.NullPointerException
...
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeRepositoriesJob.updateRepositoryConfiguration(SynchronizeRepositoriesJob.java:141)
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeRepositoriesJob.run(SynchronizeRepositoriesJob.java:85)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Comment 1 Steffen Pingel CLA 2009-10-22 17:51:09 EDT 
Also need to consider the case where synchronization failure of a single task causes incremental updates to fail (bug 290238).
Comment 2 Jörg Thönnes CLA 2009-10-23 03:11:00 EDT 
(In reply to comment #1)
> Also need to consider the case where synchronization failure of a single task
> causes incremental updates to fail (bug 290238).

Possibly, you have to provide a way to decide on a per-connector basis whether the failure is transient (may be retried) or is permanent.
And whether it only affects a specific task (which should be marked with an error) or all tasks.

1. Dimension:
* Permanent failure: Explicit refresh on the specific task is required.
* Transient failure: Refresh is tried on next automatic update.

2. Dimension:
* Specific failure: Continue incremental sync.
* General failure: Restart with full sync
Comment 3 Jörg Thönnes CLA 2009-10-23 03:13:32 EDT 
*** Bug 290238 has been marked as a duplicate of this bug. ***
Comment 4 Jörg Thönnes CLA 2009-10-23 03:15:50 EDT 
Steffen, please change title to "[performance] Guard against exceptions during synchronization"

Thanks, Jörg.
Comment 5 Steffen Pingel CLA 2010-01-05 17:17:09 EST 
Related: JIRA bug 236034.
Comment 6 Jörg Thönnes CLA 2010-05-19 06:35:43 EDT 
Why was this moved outside of 3.4? Guarding against exceptions here would be a Good Thing. Is it difficult to implement?
Comment 7 Steffen Pingel CLA 2010-05-31 16:27:43 EDT 
It's not generally difficult to implement but we need to maintain API backwards compatibility to avoid breaking any existing connector. Unfortunately I ran out of time for 3.4 and need to revisit this in the next cycle.
Comment 8 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn