Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 250982

Summary: CDTCommonProjectWizard does not report progress
Product: [Tools] CDT Reporter: Vivian Kong <vivkong>
Component: cdt-coreAssignee: Vivian Kong <vivkong>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cdt-core-inbox, cdtdoug, recoskie
Version: 5.0Flags: cdtdoug: iplog-
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 246903    
Attachments:
Description Flags
proposed patch
none
updated patch
none
patch for cdt_5_0
none
patch for cdt_5_0
none
patch for cdt_5_0
none
patch for HEAD none

Description Vivian Kong CLA 2008-10-15 13:43:35 EDT
The UI is not responsive during project creation and the progress monitor is empty.  It'd be nice to enable the progress monitor so users know that CDT is working hard.
Comment 1 Vivian Kong CLA 2008-10-15 14:41:27 EDT
Created attachment 115176 [details]
proposed patch

I used the old wizard as a reference (NewCProjectWizard) and it seems to have worked for me.  Need to define better counts for progress reporting.
Comment 2 Vivian Kong CLA 2008-10-15 21:45:15 EDT
Created attachment 115211 [details]
updated patch

adds work counts to project creation processes
Comment 3 Vivian Kong CLA 2008-10-16 13:06:45 EDT
Created attachment 115276 [details]
patch for cdt_5_0

Patch for cdt_5_0 branch
Comment 4 Chris Recoskie CLA 2008-10-17 14:05:46 EDT
The API tooling throws a bunch of errors on this.  Is there a way to do this without causing new API?
Comment 5 Vivian Kong CLA 2008-10-20 11:38:16 EDT
Created attachment 115577 [details]
patch for cdt_5_0

I eliminated all the API tooling errors for both Ganymede and Ganymede SR1 baselines in this patch.
Comment 6 Chris Recoskie CLA 2008-10-20 14:22:01 EDT
(In reply to comment #5)
> Created an attachment (id=115577)
> patch for cdt_5_0
> 
> I eliminated all the API tooling errors for both Ganymede and Ganymede SR1
> baselines in this patch.

I still see one error:

Description	Resource	Path	Location	Type
The minor version should be incremented in version 5.0.2.qualifier, since new APIs have been added since version 5.0.0.200806171202	MANIFEST.MF	org.eclipse.cdt.ui/META-INF	line 5	Version Numbering Problem
Comment 7 Vivian Kong CLA 2008-10-21 11:35:16 EDT
(In reply to comment #6)
> I still see one error:
> 
> Description     Resource        Path    Location        Type
> The minor version should be incremented in version 5.0.2.qualifier, since new
> APIs have been added since version 5.0.0.200806171202     MANIFEST.MF    
> org.eclipse.cdt.ui/META-INF     line 5  Version Numbering Problem
> 

I tried moving things around but I still need to set a ProgressMonitor on the CWizardHandler to track progress and I cannot do that without introducing new APIs.

We don't need to have a progress monitor for CWizardHandler but if we do we'll be able to provide more information on progress.
Comment 8 Vivian Kong CLA 2008-10-22 10:32:45 EDT
Created attachment 115815 [details]
patch for cdt_5_0

Removed all the new APIs added in previously proposed patches.
Comment 9 Chris Recoskie CLA 2008-10-22 11:33:38 EDT
The most recent patch for 5.0.x looks OK to me.
Comment 10 Vivian Kong CLA 2008-10-22 13:44:43 EDT
(In reply to comment #9)
> The most recent patch for 5.0.x looks OK to me.

I'll check the changes in 5.0.2 and update the patch for HEAD afterwards.

Comment 11 Vivian Kong CLA 2008-10-22 13:54:29 EDT
Fixed in cdt_5_0
Comment 12 Vivian Kong CLA 2008-11-13 11:09:47 EST
Created attachment 117791 [details]
patch for HEAD

Update cdt_5_0 patch for HEAD
Comment 13 Vivian Kong CLA 2008-11-13 11:13:03 EST
Fixed in HEAD