| Summary: | Add Goto Line to compare contexts other than Compare Editor | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Tomasz Zarna <tomasz.zarna> |
| Component: | Compare | Assignee: | Platform-Compare-Inbox <platform-compare-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | Tomasz Zarna <tomasz.zarna> |
| Severity: | normal | ||
| Priority: | P4 | CC: | daniel_megert, pwebster, Szymon.Brandys |
| Version: | 3.4 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | stalebug | ||
|
Description
Tomasz Zarna
From bug 6823, comment 26: "[...] activating "Editing Text" for Compare Editor is [not] the best solution. Compare Editor can be opened not only for text comparisons. This fact makes bug 250624 [this bug] to rise in importance. The fix for it would probably activate the context for TextMergeViewer not CompareEditor." Is it that you need to redefine some keybindings in a compare only context? Or do you mean your code should only activate the textScope context if you are working with TextMergeViewer (which also makes sense, I guess)? PW IMO the Comparing in an Editor context is to general, since the Compare Editor allows non-text input as well. For such input, actions like Goto Line don't make much sense. So I think I would go with the later, which is activating the textScope only when working with TextMergeViewer (or subclasses). We haven't investigated the issue during 3.5 and we don't plan to address it now. I'm removing the target milestone but we'll set more realistic one when we have feedback from anyone interested in fixing this. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |