Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 250162

Summary: [Theming][Button] Make CHECK and RADIO images themeable
Product: [RT] RAP Reporter: Ralf Sternberg <rsternberg>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: jsetya
Version: 1.2Keywords: plan
Target Milestone: 1.2 M5   
Hardware: All   
OS: All   
Whiteboard: plan-theme=web-features plan-status=committed
Bug Depends on:    
Bug Blocks: 224872, 250163, 252986    

Description Ralf Sternberg CLA 2008-10-08 15:37:20 EDT 
After re-implementing CHECK and RADIO buttons using images, make those images themeable.
Comment 1 Rüdiger Herrmann CLA 2009-01-05 03:43:53 EST 
*** Bug 243731 has been marked as a duplicate of this bug. ***
Comment 2 Rüdiger Herrmann CLA 2009-01-05 03:46:05 EST 
*** Bug 250160 has been marked as a duplicate of this bug. ***
Comment 3 Ralf Sternberg CLA 2009-01-30 17:07:54 EST 
Changes for CHECK buttons are in CVS.
Comment 4 Benjamin Muskalla CLA 2009-02-01 13:58:55 EST 
It seems the changes broke the ToolItems with CHECK style bit (see controls demo, Toolbar Tab). Using a CHECK toolitem leads to a javascript error at the moment..

As far as I can see the removed methods in ButtonUtil.js (checkSelected and checkSelectedAction) are still used by the CHECK toolitems.
Comment 5 Ralf Sternberg CLA 2009-02-01 15:22:43 EST 
Yes, exactly, these listeners are attached in CheckToolItemDelegateLCA. Reverted these two methods in ButtonUtil.js.
Comment 6 Rüdiger Herrmann CLA 2009-02-03 05:37:29 EST 
Does it make sense to move these methods ToolItemUtil.js
Comment 7 Ralf Sternberg CLA 2009-02-03 10:50:05 EST 
Absolutely. Moved these methods as suggested.
Comment 8 Rüdiger Herrmann CLA 2009-02-05 07:14:44 EST 
Changes for RADIO buttons are in CVS HEAD.