Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 249965

Summary: Update to Eclipse.org-common/classes/projects/
Product: Community Reporter: Nathan Gervais <nathan>
Component: WebsiteAssignee: phoenix.ui <phoenix.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: karl.matthias
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Nathan Gervais CLA 2008-10-07 10:53:46 EDT 
I've gone through the following files in /eclipse.org-common/classes/projects to update them to use the new Database API from bug 249508

categoryList.class.php
project.class.php
projectCategory.class.php
projectCategoryList.class.php
projectInfoData.class.php
projectInfoList.class.php
projectList.class.php

Please review their contents and provide a +1 if it looks ok. I'll be testing these out during the course of the week.
Comment 1 Denis Roy CLA 2008-10-08 09:17:41 EDT 
In projectCategory.class.php I still see this, and I think it's not needed:
# smart connection does not work here
if (file_exists("/home/data/httpd/eclipse-php-classes/system/dbconnection_rw.class.php")) {
  require_once "/home/data/httpd/eclipse-php-classes/system/dbconnection_rw.class.php";
}

=================================
In projectInfo.class.php

retrieval is in fact the correct spelling, not retreival.  Don't forget the 'I before E except after C' rule.

Also, I believe  $App->projectinfo_sql is not a wrong option here.  I'm not sure which is better between  $App->projectinfo_sql and eclipse_sql.  In the end it probably doesn't matter. Karl?

The rest all looks dandy...  Thanks!
Comment 2 Nathan Gervais CLA 2008-10-08 09:36:50 EDT 
(In reply to comment #1)
> In projectCategory.class.php I still see this, and I think it's not needed:
> # smart connection does not work here
> if
> (file_exists("/home/data/httpd/eclipse-php-classes/system/dbconnection_rw.class.php"))
> {
>   require_once
> "/home/data/httpd/eclipse-php-classes/system/dbconnection_rw.class.php";
> }
> 

Removed, guess my brain parser wasn't really looking for this, thanks for catching it.
> =================================
> In projectInfo.class.php
> 
> retrieval is in fact the correct spelling, not retreival.  Don't forget the 'I
> before E except after C' rule.

Those pesky comment spelling mistakes! Fixed.
 
> Also, I believe  $App->projectinfo_sql is not a wrong option here.  I'm not
> sure which is better between  $App->projectinfo_sql and eclipse_sql.  In the
> end it probably doesn't matter. Karl?

I coded them with eclipse_sql but will happily change them to projectinfo_sql if thats what's decided.
Comment 3 Karl Matthias CLA 2008-10-08 12:07:41 EDT 
(In reply to comment #1)
> Also, I believe  $App->projectinfo_sql is not a wrong option here.  I'm not
> sure which is better between  $App->projectinfo_sql and eclipse_sql.  In the
> end it probably doesn't matter. Karl?

Probably doesn't matter... the eclipse_sql calls dbconnection.class.php which is not path protected at all so it should be fine.
Comment 4 Nathan Gervais CLA 2008-10-31 10:48:27 EDT 
Closing this as fixed.