Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 249482

Summary: Duplicate Filters can be created if changing the filter pool
Product: [Tools] Target Management Reporter: Kevin Doyle <kjdoyle>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: kjdoyle, rdibugs
Version: 3.0.1   
Target Milestone: 3.1 M4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 256487    
Attachments:
Description Flags
patch with connection-unique awareness none

Description Kevin Doyle CLA 2008-10-02 09:31:15 EDT 
If I change the filter pool then check "Only create filter in this connection." the validator is not the connection private one and I can create a duplicate filter for that filter pool.

Steps to Reproduce:
1. On a Linux connection right click on the Files subsystem and Go New -> Filter.  Enter in some information for the filter.
2. On the Files Subsystem go New -> Filter.
3. Enter a name that is the same as the previous filter.
4. Deselect the check for only this connection.
5. Change the filter pool to the default filter pool for that subsystem.
6. Select the check box for only this connection.
--> I can click Finish and the filter will show up in the remote systems view but with the filter strings of the first filter.
Comment 1 Martin Oberhuber CLA 2008-10-02 10:07:53 EDT 
Your bug is filed against version 3.0 -- note that bug 238158 and bug 235223 have been fixed for 3.0.1.
Comment 2 Kevin Doyle CLA 2008-10-02 10:22:44 EDT 
I haven't updated by bug template that is why it shows 3.0 still.  Changed to 3.0.1.  This is still a bug and a case that was missed from Bug 238158.
Comment 3 David McKnight CLA 2008-11-14 15:11:39 EST 
Created attachment 117939 [details]
patch with connection-unique awareness

This patch addresses things by not allowing a non-connection unique filter pool to be set when the unique connection checkbox is set.  Also if the checkbox is not set, then the selected filter pool can not be the connection unique filter pool.  One thing I'm not sure about is whether it's safe to assume the filter pool is connection-unique when it's the same as the parentPool.
Comment 4 David McKnight CLA 2008-11-25 14:02:30 EST 
I've committed the fix to cvs.
Comment 5 David McKnight CLA 2008-11-25 14:03:35 EST 
*** Bug 249886 has been marked as a duplicate of this bug. ***
Comment 6 Kevin Doyle CLA 2008-11-25 14:23:59 EST 
Dave, can we backport this fix?  Thanks.
Comment 7 David McKnight CLA 2008-11-25 14:32:35 EST 
(In reply to comment #6)
> Dave, can we backport this fix?  Thanks.
> 

Opened bug 256487 for the backport.