Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 248623

Summary: Add icons for module dependencies in EAR wizard
Product: [WebTools] WTP Java EE Tools Reporter: Kaloyan Raev <kaloyan>
Component: jst.j2eeAssignee: Milen Manov <milen.manov>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: enhancement    
Priority: P3 CC: dimitar.giormov
Version: 3.0Keywords: plan
Target Milestone: 3.2 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard: EaseOfUse
Attachments:
Description Flags
almost working proposal
none
patch
kaloyan: iplog+
patch with corrections kaloyan: iplog+

Description Kaloyan Raev CLA 2008-09-25 12:40:28 EDT 
There should be icons for easy determination of the Module/JAR type of the possible EAR dependencies. Such icons are missing in:
  * the Java EE Module Dependencies property page for EAR project. 
  * the Java EE Module Dependencies list in the EAR wizard.
Comment 1 Dimitar Giormov CLA 2008-12-11 04:54:31 EST 
Created attachment 120169 [details]
almost working proposal

here sometimes the decorators are not shown, I still cannot find why.
Comment 2 Milen Manov CLA 2009-04-09 04:32:17 EDT 
Created attachment 131379 [details]
patch
Comment 3 Kaloyan Raev CLA 2009-04-10 09:19:30 EDT 
Milen, this works fine for the EAR wizard. 
It also partially work for the Java EE Module Dependencies property page - in the case of projects in workspace. It seems to corrupt the case where an external jar is added. Please, test this use case as well. 

Also there are some minor tweaks needed to be done on the patch:
  - there are some commented code that needs to be removed 
  - set access modifier for "ITableLabelProvider tableLableProvider" in J2EEComponentLabelProvider
Comment 4 Milen Manov CLA 2009-04-13 06:45:46 EDT 
Created attachment 131633 [details]
patch with corrections

The following patch covers issues described in Kaloqn's comment
Comment 5 Dimitar Giormov CLA 2009-06-29 09:17:13 EDT 
Milen the external jars are marked with ear project icon instead of traditional jar icon.
Comment 6 Kaloyan Raev CLA 2009-09-17 12:53:46 EDT 
The Java EE Module Dependencies property page is going to be replaced by the new Module Assembly property page. Therefore, I reduce the scope of this bug to only the EAR wizard page.
Comment 7 Kaloyan Raev CLA 2009-10-14 10:30:01 EDT 
Committed to HEAD