Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 247283

Summary:	API changes
Product:	[Modeling] EMFCompare	Reporter:	Laurent Goubet <laurent.goubet>
Component:	Core	Assignee:	EMF Compare <emf.compare-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	1.0
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	232277

Description Laurent Goubet

2008-09-15 08:10:50 EDT

Looking through the DiffModel and MatchModel, I stumbled upon some elements that are either obsolete or in need of a renaming. This bug is intended to be a list of each of the changes that should take place before 1.0 is released.

DiffModel :
- GenericDiffElement has no longer any existence in the code and should be removed

MatchModel :
- Match2Elements should be renamed Match2Element so as to follow the same rule as Match3Element
- UnMatchElement should be renamed UnmatchedElement, RemoteUnMatchElement has to be renamed the same way.

Comment 1 Laurent Goubet

2008-09-23 10:45:17 EDT

Since bug 232277 needs the diff metamodel to be refactored in order to be fixed, we might as well take this chance to fully refactor both metamodels to enhance consistency. Here is the complete list of changes that will be done during this "refactoring session" :) :

DiffModel :
- GenericDiffElement will be deleted
- DiffGroup#leftParent will be renamed DiffGroup#rightParent

- AddModelElement and RemoteRemoveModelElement supertypes will be changed from ModelElementChangeRightTarget to ModelElementChangeLeftTarget
- RemoveModelElement and RemoteAddModelElement supertypes will be changed from ModelElementChangeLeftTarget to ModelElementChangeRightTarget

- AddAttribute and RemoteRemoveAttribute supertypes will be changed from AttributeChangeRightTarget to AttributeChangeLeftTarget
- RemoveAttribute and RemoteAddAttribute supertypes will be changed from AttributeChangeLeftTarget to AttributeChangeRightTarget

- AddReferenceValue and RemoteRemoveReferenceValue supertypes will be changed from ReferenceChangeRightTarget to ReferenceChangeLeftTarget
- RemoveReferenceValue and RemoteAddReferenceValue supertypes will be changed from ReferenceChangeLeftTarget to ReferenceChangeRightTarget


MatchModel :
- MatchModel#unMatchedElements will be renamed MatchModel#unmatchedElements
- Match3Element will be renamed Match3Elements
- UnMatchElement will be renamed UnmatchedElement
- RemoteUnMatchElement will be renamed RemoteUnmatchedElement

Comment 2 Laurent Goubet

2008-09-23 12:08:35 EDT

Changes have been commited on HEAD and will be available in the next build.

Comment 3 Laurent Goubet

2009-01-05 03:43:42 EST

FIX available in 0.9.0M4.

Comment 4 Laurent Goubet

2011-08-18 04:06:15 EDT

Closing our "resolved" and "verified" bugs.