Bugzilla – Full Text Bug Listing
| Summary: | [CommonNavigator] Why is getLinkHelperService private? | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Rob Stryker <stryker> |
| Component: | UI | Assignee: | Francis Upton IV <francisu> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | francisu |
| Version: | 3.4 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
*** This bug has been marked as a duplicate of bug 250198 *** |
It is impossible (or difficult) to subclass some parts of the CommonNavigator because getLinkHelperService() is private. For example: protected ActionGroup createCommonActionGroup() { return new CommonNavigatorActionGroup(this, commonViewer, getLinkHelperService()); } createCommonActionGroup is protected and overrideable, but CommonNavigatorActionGroup, and probably any replacement for it, would require access to the link helper service. A subclass has no way to gain access to this variable at all. As the link helper service itself is pretty safe and contains mostly getters, I think making CommonNavigator.getLinkHelperService() a protected method rather than a private one.