Bugzilla – Full Text Bug Listing
| Summary: | UI improvements the 'Servers' view | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP ServerTools | Reporter: | Angel Vera <arvera> | ||||
| Component: | wst.server | Assignee: | Angel Vera <arvera> | ||||
| Status: | CLOSED FIXED | QA Contact: | Tim deBoer <deboer> | ||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | deboer, eyuen7, kaloyan, thatnitind, yenlu | ||||
| Version: | 3.0 | Keywords: | plan | ||||
| Target Milestone: | 3.1 RC1 | Flags: | arvera:
pmc_approved?
(david_williams) arvera: pmc_approved? (raghunathan.srinivasan) arvera: pmc_approved? (naci.dai) arvera: pmc_approved? (deboer) arvera: pmc_approved? (neil.hauge) kaloyan: pmc_approved+ deboer: review+ |
||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| See Also: |
https://git.eclipse.org/r/108744 https://git.eclipse.org/r/108788 |
||||||
| Whiteboard: | PMC_approved | ||||||
| Attachments: |
|
||||||
|
Description
Angel Vera
ops.. typo.. fixing the typo: Continue to look at the 'Servers' view [to] drive enhancements by providing more extension support and better usability. We will consider bug 245013, part of this item. Angel, if a user has several servers with names of different lengths, those labels in square brackets may start looking messy. In the example shown on http://www.eclipse.org/webtools/development/news/3.1M4/server.php, what exactly does "Restart" in square brackets after the state actually mean? Does it mean the server can be restarted or does it mean the server is restarting? What would happen if a server is starting or stopping or a project was publishing? Would the publishing status show up on the server or on the project child? If it is the child, what if the child is hidden? (In reply to comment #3) Yen, We haven't change the meaning of the labels nor did we change the order of the labels. So the first text that shows in square brackets most of the time would match to the state of the Server: Stopped, Started, Starting,Stopping,... The second label, shows the status of the Server: Synchronized, Restart, Publishing,... The concepts haven't changed from the old Servers view. I expect experienced users to be familiar with the labels. But having said that, I do realized that new users could be confused about the meaning of the labels. But after some usage I expect they would realized the meaning of the labels. If you have any suggestion on how to reduce the learning curve for new users, other than updating the help documentation, I am will be glad to consider options. Currently I am not aware of any adopter providing hidden modules, in the old view this wasn't possible unless you did some mayor reworked to the view. But in the new Servers view an adopter can potentially provide filtering and hide a module. But on doing so, they need to be aware of the consequences, which in this case means that no UI will be provided for that module. If a module is hidden the user doesn't have capabilities of knowing the status/state of that module. Correct API implementation is required to update the necessary bits. We provide a mechanism to update this flag by calling the correct API in org.eclipse.wst.server.core.model.ServerBehaviourDelegate.setModuleState(IModule[], int). Is it wise to rely on decorators for functionality that used to just be "on" (particularly with no description given in the UI)? It's possible for the user to disable any and all decorators. (In reply to comment #5) The functionality is still on by default, the only difference is that we are not providing the description of the labels within the view. We did the changes following the example from the 'CVS label decorator' in the project explorer when you check out a project. Implementing the label decorators is the best way that we thought we could maintain the same functionality that was offered in the old view. We could add the word, 'State' and 'Status' in front of the decorators if that is something we think will help, but I personally (as an advanced user) don't find a lot of benefit to have a label that just consumes space and doesn't change. Perhaps we can make it an option? When discussing the redesign, we indeed discuss the impact that this changes would have, but the benefits were overweight by the adoption of CNF. As I in the previous comment as well, If you have any suggestion on how to indicate the meaning of the label, other than updating the help documentation, I will be glad to consider options. Also note, that there is a lot of background information on bug# 247934 and bug# 245013, that might be of your interest. *** Bug 222588 has been marked as a duplicate of this bug. *** updated wrong bug Created attachment 135908 [details]
v1 (remove of deprecated view)
* Give a brief technical overview. Who has reviewed this fix? This bug is to remove the old servers view which has been deprecated since M5-M6. A new Servers view was committed in M4 and was changed to be the default view in M5-M6. This last change is to remove the view from being displayed under the Views menu, as we do not want to have two views available by the time we ship 3.1 In M5-M6 we replaced views ids by swapping the ids of the views. That enabled us to have the new view as the default and avoid migration problems. Old workspaces that have the view open will just open the new servers view because the ids are the same. * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. This is an important bug for 3.1 because it complete the changes planned for this enhancements. * Is there a work-around? If so, why do you believe the work-around is insufficient? N/A * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? The attached patches has been tested locally. * What is the risk associated with this fix? low, as this is just removing the view definition. +1 pending project lead's review. Tim, over to you for team lead approval Approved. Low impact patch to cleanup old Servers view that is no longer used. Changes dropped to HEAD Verified the changes are in the build verified closing Updating to the correct milestone when the last changes for this enhancement where dropped into the build. New Gerrit change created: https://git.eclipse.org/r/108744 New Gerrit change created: https://git.eclipse.org/r/108788 |