Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 245991

Summary: Client Project defaults back to first facet friendly workspace project after changing WSDL selection
Product: [WebTools] WTP Webservices Reporter: Shane Clarke <shane_clarke>
Component: jst.wsAssignee: Eric Peters <ericdp>
Status: RESOLVED WONTFIX QA Contact: Kathy Chan <kathy>
Severity: normal    
Priority: P3 CC: oisin.hurley
Version: 3.0   
Target Milestone: 3.1   
Hardware: Macintosh   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
Updates to ClientWizardWidget none

Description Shane Clarke CLA 2008-09-02 13:04:59 EDT
Created attachment 111505 [details]
Updates to ClientWizardWidget

Build ID: I20080617-2000

Steps To Reproduce:
1.Create two dynamic web projects in your workspace. A and B.
2.Add a wsdl file to each each project.
3.Open the Web Service Client wizard with no initial selection in the project explorer.

The "Client Project" defaults to the first facet friendly project. Project A.

The Service definition field is blank.

Select Browse. (WSDLSelectionDialog initialized with null project value).

Select Browse on the WSDLSelectionDialog and select the wsdl file in project B.

WSDLSelectionDialog project field is correctly updated.

However on closing the WSDLSelectionDialog  the project field in ClientWizardWidget isn't updated correctly.

callObjectTransformation in widgetSelected is called with the original null project value.

More information:
Tested against latest from HEAD 9th Sep 08.

This bug also applies to the case where there was an initial selection in the project explorer. The initial project is persisted after changing the wsdl selection to a different project.

Solution:

2 Steps:

callObjectTransformation is called from widgetSelect with the updated project value that was set in the WSDLSelectionDialog

and

After calling setProject in callObjectTransformation. Update the Client Project Name as well.

Patch attached
Comment 1 Shane Clarke CLA 2008-09-02 13:11:13 EDT
Wrong date. Tested against the latest today 2nd September.
Comment 2 Kathy Chan CLA 2008-09-03 16:14:25 EDT
Eric,

Please take a look at this problem reported.  Thanks!
Comment 3 Eric Peters CLA 2008-11-17 13:09:44 EST
Hi Shane,

The change in behavior is very similar to that requested in https://bugs.eclipse.org/bugs/show_bug.cgi?id=243290 but this time on the client side. Please see my comments to 243290 as to why the existing behavior is working as designed, and let us know if there is a compelling reason we've not considered that we should make this change.

Thanks,
Comment 4 Kathy Chan CLA 2009-02-11 22:00:56 EST
This bug has been in resolved state for a while (with resolution set to Invalid, Duplicate, wontfix or workforme).  Please verify that you're OK with this resolution and close the defect.  Please re-open if you don't agree with this assessment.

If this is not verified within 2 weeks, we'll be verifying the bug on your behalf.  Thanks!
Comment 5 Shane Clarke CLA 2009-02-18 11:44:34 EST
Ok with the resolution. Closing.