Bug 245531

Description Don Yantzi 2008-08-28 09:43:15 EDT

1. Right click on a connection and select copy.
2. In the Copy Resource dialog, select the same RSE profile as the connection and click OK
3. Duplicate name collision dialog appears. Select to overwrite.
4. RSEG1041Q appears saying "Connection of name .... already exists in profile ..... Continue?
5. Click Yes.

A NPE is displayed:

!ENTRY org.eclipse.rse.ui 4 0 2008-08-28 09:38:59.779
!MESSAGE RSEG1066U: SUB#0:java.lang.NullPointerException
!STACK 0
java.lang.NullPointerException
	at java.util.Hashtable.put(Unknown Source)
	at org.eclipse.rse.core.subsystems.SubSystemConfiguration.cloneSubSystem(SubSystemConfiguration.java:1065)
	at org.eclipse.rse.internal.core.model.SystemRegistry.copyHost(SystemRegistry.java:2094)
	at org.eclipse.rse.internal.ui.actions.SystemCopyConnectionAction.doCopy(SystemCopyConnectionAction.java:128)
	at org.eclipse.rse.ui.actions.SystemBaseCopyAction.run(SystemBaseCopyAction.java:319)
	at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:446)
	at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:354)

SystemRegistry.copyHost calls "oldPool.cloneHost(...)", however the cloneHost ultimately calls SystemHostPool.createHost which has the following check:

boolean exists = getHost(aliasName) != null;
if (exists)
{
     return null;
}

As a side note, the details for the message RSEG1041Q should be changed from:

"... While this allowed, ..."

to 

"... While this is allowed, ..."

Or maybe it shouldn't be allowed?