Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 244475

Summary:

outline does not expand comments from collapsed subsections

Product:

z_Archived

Reporter:

Steffen Pingel <steffen.pingel>

Component:

Mylyn

Assignee:

Jingwen 'Owen' Ou <jingweno>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

Version:

unspecified

Target Milestone:

3.1

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

238038

Attachments:

Description	Flags
mylyn/context/zip	none
a patch that fixed the problem	none
simpler solution	none
mylyn/context/zip	none

Description Steffen Pingel

2008-08-18 16:39:14 EDT

If a comment is selected in the outline that is in a collapsed subsection the subsection is not expanded.

Comment 1 Steffen Pingel

2008-08-18 17:19:37 EDT

There might not be a trivial fix since the current implementation is kind of hackish and does some special handling of comments (see attached context).

Comment 2 Steffen Pingel

2008-08-18 17:19:41 EDT

Created attachment 110290 [details]
mylyn/context/zip

Comment 3 Jingwen 'Owen' Ou

2008-08-24 23:25:20 EDT

Created attachment 110765 [details]
a patch that fixed the problem

The reason is the comments under each subsections are built lazily. WHile toggling the main section, we need to also toggle the subsecions before EditorUtil.findControl()

Comment 4 Steffen Pingel

2008-09-20 02:36:48 EDT

Created attachment 113057 [details]
simpler solution

Comment 5 Steffen Pingel

2008-09-20 02:36:52 EDT

Created attachment 113058 [details]
mylyn/context/zip

Comment 6 Steffen Pingel

2008-09-20 02:39:04 EDT

Thanks for your patch. I am a bit concerned that expanding all expandable composites could have a negative performance. I have taken a similar approach that limits the changes to handle the comment section specifically.

Comment 7 Jingwen 'Owen' Ou

2008-10-14 13:43:27 EDT

Steffen, did u apply this patch? The outline should work now?

Comment 8 Steffen Pingel

2008-10-14 15:58:41 EDT

Yes, the patch was applied. I was mistaken on todays call. Sorry about that.