Bugzilla – Full Text Bug Listing
| Summary: | Duplicating colon in error message prefix | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Inocencio Richiez <irichiez> | ||||||||
| Component: | UI | Assignee: | Kit Lo <kitlo> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | contact, kitlo, Lars.Vogel, Vikas.Chandra | ||||||||
| Version: | 3.5 | ||||||||||
| Target Milestone: | 4.11 M1 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| See Also: |
https://git.eclipse.org/r/133797 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=b9a0a04566089d81f1909d3ea4733a11c62eb944 |
||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
First of all, it's DBCS (double byte languages, which includes Simplified Chinese, Traditional Chinese, Japanese, Korean) languages' convention to put the mnemonic char in parenthesis at the end of the string. However, looks like PDE is reusing the field prompt string in the message, causing "(V)" to be displayed. That's the first problem. I also noticed that when Simplified Chinese and Traditional Chinese translate the single byte colon into a double byte colon, an extra colon is inserted "programmatically", I think. Both problems are coding problems in PDE. Assigning to PDE to investigate. Thank you very much Kit, the two points you are highlighting are indeed issues in PDE itself. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. Please reopen if you plan to provide a patch. We should format message with MessageFormat instead of programmatically removing mnemonic and adding colon. New Gerrit change created: https://git.eclipse.org/r/133705 Created attachment 276867 [details]
Test result in English.png
English message is still displaying correctly
Created attachment 276868 [details]
Test result in Traditional Chinese.png
Message in Traditional Chinese with mnemonic "(V)" is removed and no duplicating colon
New Gerrit change created: https://git.eclipse.org/r/133734 Lars, I abandoned the second Gerrit change and tried to commit the update with the same change-id, but received this message: "same Change-Id in multiple changes. Squash the commits with the same Change-Id or ensure Change-Ids are unique for each commit" Please provide the instructions for adding the update as patch set 2. Thanks! (In reply to Kit Lo from comment #10) > Lars, I abandoned the second Gerrit change and tried to commit the update > with the same change-id, but received this message: "same Change-Id in > multiple changes. > Squash the commits with the same Change-Id or ensure Change-Ids are unique > for each commit" > > Please provide the instructions for adding the update as patch set 2. Thanks! See http://www.vogella.com/tutorials/Gerrit/article.html#gerrit_problems_squashcommits and http://www.vogella.com/tutorials/Gerrit/article.html#combining-changes-from-two-commits-gerrit-change-reviews for detailed instructions. New Gerrit change created: https://git.eclipse.org/r/133797 Lars, thanks for the instructions. Very helpful. However, I saw a commit in between mine. Just to be safe, I started fresh again. Please review the latest Gerrit change: https://git.eclipse.org/r/133797 Thanks! Thanks, Kit. Gerrit change https://git.eclipse.org/r/133797 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=b9a0a04566089d81f1909d3ea4733a11c62eb944 Can someone verify this fix? (In reply to Vikas Chandra from comment #16) > Can someone verify this fix? Kit, please verify. I verified the fix in 4.11-I-build I20190103-1800 |
Created attachment 110271 [details] message with double semicolons Build ID: I20080609-1311 Steps To Reproduce: 1.Set your enviroment to Traditional Chinese (zh_TW) 2. Create a Plugin project 2.In the Plug-in Content page, set the Plug-in Version to e.g. *1.0.0 (to force the error message) 3.The error message displayed ont he wizard contain two (2) semicolons. More information: