Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 244171

Summary: [ActivityMgmt] (maintenance) NPE in org.eclipse.ui.internal.activities.Identifer prevents menu contributions from showing up
Product: [Eclipse Project] Platform Reporter: Kim Horne <eclipse>
Component: UIAssignee: Kim Horne <eclipse>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: chanskw, clin, remy.suen
Version: 3.4   
Target Milestone: 3.4.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 243209    
Bug Blocks:    
Attachments:
Description Flags
Patch against org.eclipse.ui.workbench eclipse: iplog+

Description Kim Horne CLA 2008-08-14 10:43:09 EDT 
+++ This bug was initially created as a clone of Bug #243209 +++

Build ID: I20080617-2000 (Version 3.4.0)

In the code of Identifier.removeIdentifierListener(), only part of the code is guarded aganist NPEs.  When the NPE occurs, menu contributions don't show up.  A patch is attached to fix the problem.
Comment 1 Kim Horne CLA 2008-08-14 10:49:46 EDT 
Created attachment 109989 [details]
Patch against org.eclipse.ui.workbench
Comment 2 Kim Horne CLA 2008-08-14 10:50:29 EDT 
Fix in R3_4_maintenance.
Comment 3 Kim Horne CLA 2008-08-28 12:45:13 EDT 
Verified by source inspection in M20080827-2000