Bugzilla – Full Text Bug Listing
| Summary: | first API addition causes cascade of errors | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Darin Wright <darin.eclipse> |
| Component: | API Tools | Assignee: | Vikas Chandra <Vikas.Chandra> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | curtis.windatt.public, daniel_megert, Lars.Vogel, Michael_Rennie, Olivier_Thomann, Vikas.Chandra |
| Version: | 3.4 | Keywords: | noteworthy |
| Target Milestone: | 4.13 M1 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| See Also: |
https://git.eclipse.org/r/145366 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=1aace0178242bc1548108225851b5caf9fe7f1bf https://git.eclipse.org/r/145396 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=5fde2c88d5031beea616762bd36cba5861ace1e9 https://git.eclipse.org/r/145682 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=58de1189e357f7c2db6f996a54b01756ab45aa5e |
||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 549370 | ||
|
Description
Darin Wright
*** Bug 321685 has been marked as a duplicate of this bug. *** Besides the cascade of errors, showing the wrong @since tag in the quick fix is really an issue for (new) developers because they either get uncertain about what the correct @since tag is or about the quality of API tooling. For me this is a major flaw. Can we look at this for 3.7? When new API is added to a bundle a developer generally wants to increment the bundle version and add the new @since tag. There may be corner cases where API is being added to a patch release and one wants to suppress minor bundle version increments. However, I'm not sure we should offer a quick fix for such cases, as they are uncommon and go against the Eclipse rules of version numbering. When there are @since tag problems and bundle version problems, we should probably offer a quick fix that fixes both issues at once - increment the bundle version, and add the @since tag (with new / correct version number). Currently the problems are treated individually. We can still offer a single quick fix for incrementing the bundle version number (i.e. problem on the Manifest). I think this just requires changes to how the quick fix is generated. Targetting for 3.7. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. New Gerrit change created: https://git.eclipse.org/r/145366 Gerrit change https://git.eclipse.org/r/145366 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=1aace0178242bc1548108225851b5caf9fe7f1bf >quick fix that increments the bundle version and creates an @since tag with the >right version number the first time.
Done
New Gerrit change created: https://git.eclipse.org/r/145396 Gerrit change https://git.eclipse.org/r/145396 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=5fde2c88d5031beea616762bd36cba5861ace1e9 verified on Version: 2019-09 (4.13) Build id: I20190708-1800 New Gerrit change created: https://git.eclipse.org/r/145682 Gerrit change https://git.eclipse.org/r/145682 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=58de1189e357f7c2db6f996a54b01756ab45aa5e |