Bugzilla – Full Text Bug Listing
| Summary: | [typing] Tab is not indenting line in Java editor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Andrew Gvozdev <angvoz.dev> | ||||||
| Component: | Text | Assignee: | Dani Megert <daniel_megert> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert | ||||||
| Version: | 3.4 | ||||||||
| Target Milestone: | 3.5 M2 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 109490 [details]
patch
suggested patch
Created attachment 109491 [details]
patch
suggested patch
The patches are wrong since they don't check whether the corresponding smart Tab preference is enabled or not. Fixed in HEAD. Will be in next M2 build. The patch is working fine, thank you Daniel. (In reply to comment #4) > The patch is working fine, thank you Daniel. I'd like to add something to that. The case stated in the description is working fine. However there is still something wrong. Set preferences as described in the description (also assuming that tab/ident width is 4) and consider following case (spaces are represented by dot "."): public class Indent { ....void f() { ........; ....} } 1. Save the file. Editor window tab is not marked with "*". 2. Select and copy to clipboard 5 spaces. Place the cursor just before the semicolon and paste. The spaces are not added. The contents of the editor are not changed, however the editor window tab is marked with "*" indicating that the file changed. 3. Select 2 spaces and copy at the same position. The spaces added. If you use tab settings, pressing a tab in that position would add indentation. I think that if a user explicitly pastes a sequence of spaces he expects that it would be inserted as well. Please file a new bug report since pasting and typing are not the same. Also, please check bugzilla first whether there are related bugs for this already. New bug 243880 created. Thanks, Daniel. |
1. In Window>Preferences>Java>Editor>Typing uncheck "Tab key adjusts the indentation of the current line". 2. Go to the "formatter preference page" (the easiest to follow the link). Create custom style setting "Tab policy" to "Spaces only" ("Mixed" also got the problem). Apply the style. 3. Edit Java file. Enabling "Show whitespace characters" to see all spaces/tabs might be beneficial. Enter the example in the file. Make sure the semicolon at the 3-rd line is at the first position: void main() { for(;;) ; } Place the cursor before that single semicolon at the 3-rd line. 4. Press Tab key 3 times. The cursor jumps 8 characters (indenting after "for") the first time and not moving anymore. The correct behavior would be to advance adding 4 more spaces (equal indentation size) each time - since "Tab key adjusts the indentation of the current line" is unchecked. See also bug 242707 for identical bug in CDT C++ editor.