| Summary: | IAC cannot start on Linux all-in-one | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Eugene Chan <ewchan> | ||||||||||
| Component: | TPTP | Assignee: | Bing Xu <xubing> | ||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||
| Severity: | blocker | ||||||||||||
| Priority: | P1 | CC: | jcayne, jgwest, jkubasta, paulslau | ||||||||||
| Version: | unspecified | Flags: | ewchan:
review+
|
||||||||||
| Target Milestone: | --- | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eugene Chan
the IAC config file seems empty in the first place. if I try to start the IAC as a standalone AC after runing ./SetConfig, I see the following error [root@fvtlinux5 bin]# ./ACServer ./ACServer: error while loading shared libraries: libtptpUtils.so.4: cannot open shared object file: No such file or directory. Created attachment 109456 [details]
Fix how ACStart.sh is called on Linux
With run 'ACServer -d "config"' on Linux, the "" are not removed from argc. Since Linux directory names usually don't contain space I am removing the "" from AC invokation. Jonathan, can you review the code? Thanks. I think it's very risky to assume the Linux path has no space in it. Will discuss with Jonathan and see if we can remove the "" in native code. Created attachment 109535 [details]
Patch to remove the "" around the argument in native code.
Jonathan, can you review it. Thanks. Patch is good. patch committed to Head with PMC approval Created attachment 109682 [details]
Update config dir path.
Jonathan, can you review the code change.
Failed on Linux em64t. Reopen bug, Bing, Please give more information regarding your latest attachment? What problem/issue does the patch address? is it a regression from the last patch? Patch is good. Hi Eugene, with the latest build, the IAC fails to start on Linux (confirmed on IA32 and EM64T). This patch should fix the problem. The code removes the quotation marks from the path (of the -D option) if they are passed in, however, the final modified string was not being outputted to the appropriate variable. This patch fixes the problem. Thanks Jonathan, Is there a way to build and attach the dll for testing and verification of the patch? Created attachment 109688 [details]
ACServer for Linux IA32 with 2nd patch
(In reply to comment #16) > Created an attachment (id=109688) [details] > ACServer for Linux IA32 with 2nd patch > Tested patch on Linux RHEL50 ia32 and works okay. (In reply to comment #17) > (In reply to comment #16) > > Created an attachment (id=109688) [details] [details] > > ACServer for Linux IA32 with 2nd patch > > > > Tested patch on Linux RHEL50 ia32 and works okay. > There was a problem but it was about the permission setting of the ACServer file saved on the machine. It works fine after I chmod to executable. patch committed to Head with PMC approval CLOSE BUG |