Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 243431

Summary: IAC cannot start on Linux all-in-one
Product: z_Archived Reporter: Eugene Chan <ewchan>
Component: TPTPAssignee: Bing Xu <xubing>
Status: CLOSED FIXED QA Contact:
Severity: blocker    
Priority: P1 CC: jcayne, jgwest, jkubasta, paulslau
Version: unspecifiedFlags: ewchan: review+
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Fix how ACStart.sh is called on Linux
none
Patch to remove the "" around the argument in native code.
none
Update config dir path.
none
ACServer for Linux IA32 with 2nd patch none

Description Eugene Chan CLA 2008-08-07 11:16:36 EDT
on Linux RHEL5.0
1. unzip all-in-one 08060100.
2. start eclipse workbench.
3. Go to Preferecens > IAC > Host > Test Connection. 
4. IAC failed to start.

Joel, could you confirm the use case on your machine also?
Comment 1 Eugene Chan CLA 2008-08-07 11:46:37 EDT
the IAC config file seems empty in the first place.

if I try to start the IAC as a standalone AC after runing ./SetConfig, I see the following error
[root@fvtlinux5 bin]# ./ACServer
./ACServer: error while loading shared libraries: libtptpUtils.so.4: cannot open
 shared object file: No such file or directory.

Comment 2 Bing Xu CLA 2008-08-07 16:43:49 EDT
Created attachment 109456 [details]
Fix how ACStart.sh is called on Linux
Comment 3 Bing Xu CLA 2008-08-07 16:46:39 EDT
With run 'ACServer -d "config"' on Linux, the "" are not removed from argc. Since Linux directory names usually don't contain space I am removing the "" from AC invokation.

Jonathan, can you review the code?  Thanks.
Comment 4 Eugene Chan CLA 2008-08-07 17:05:19 EDT
I think it's very risky to assume the Linux path has no space in it.
Comment 5 Bing Xu CLA 2008-08-07 17:12:03 EDT
Will discuss with Jonathan and see if we can remove the "" in native code.
Comment 6 Bing Xu CLA 2008-08-08 11:06:53 EDT
Created attachment 109535 [details]
Patch to remove the "" around the argument in native code.
Comment 7 Bing Xu CLA 2008-08-08 11:07:33 EDT
Jonathan, can you review it.  Thanks.
Comment 8 Jonathan West CLA 2008-08-08 11:15:17 EDT
Patch is good.
Comment 9 jkubasta CLA 2008-08-08 12:17:41 EDT
patch committed to Head with PMC approval
Comment 10 Bing Xu CLA 2008-08-11 12:56:33 EDT
Created attachment 109682 [details]
Update config dir path.

Jonathan, can you review the code change.
Comment 11 Bing Xu CLA 2008-08-11 12:58:11 EDT
Failed on Linux em64t.
Comment 12 Eugene Chan CLA 2008-08-11 12:59:35 EDT
Reopen bug, Bing, Please give more information regarding your latest attachment? What problem/issue does the patch address? is it a regression from the last patch?
Comment 13 Jonathan West CLA 2008-08-11 13:02:06 EDT
Patch is good.
Comment 14 Jonathan West CLA 2008-08-11 13:05:58 EDT
Hi Eugene, with the latest build, the IAC fails to start on Linux (confirmed on IA32 and EM64T). This patch should fix the problem. The code removes the quotation marks from the path (of the -D option) if they are passed in, however, the final modified string was not being outputted to the appropriate variable. This patch fixes the problem.
Comment 15 Eugene Chan CLA 2008-08-11 13:24:58 EDT
Thanks Jonathan,
Is there a way to build and attach the dll for testing and verification of the patch?
Comment 16 Bing Xu CLA 2008-08-11 13:30:24 EDT
Created attachment 109688 [details]
ACServer for Linux IA32 with 2nd patch
Comment 17 Eugene Chan CLA 2008-08-11 13:46:40 EDT
(In reply to comment #16)
> Created an attachment (id=109688) [details]
> ACServer for Linux IA32 with 2nd patch
> 

Tested patch on Linux RHEL50 ia32 and works okay.
Comment 18 Eugene Chan CLA 2008-08-11 13:47:39 EDT
(In reply to comment #17)
> (In reply to comment #16)
> > Created an attachment (id=109688) [details] [details]
> > ACServer for Linux IA32 with 2nd patch
> > 
> 
> Tested patch on Linux RHEL50 ia32 and works okay.
> 

There was a problem but it was about the permission setting of the ACServer file saved on the machine. It works fine after I chmod to executable.
Comment 19 jkubasta CLA 2008-08-11 15:55:39 EDT
patch committed to Head with PMC approval
Comment 20 Eugene Chan CLA 2009-02-24 17:10:34 EST
CLOSE BUG