Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 241557

Summary: PostgreSQL sequences not supported
Product: [Tools] Data Tools Reporter: Brian Vosburgh <brian.vosburgh>
Component: EnablementAssignee: Brian Payton <bpayton>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: bpayton, pierre.queinnec
Version: GanymedeKeywords: helpwanted
Target Milestone: 1.9.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 241578, 359861    
Attachments:
Description Flags
PG sequences support
none
Patch in EGit default format bpayton: iplog+

Description Brian Vosburgh CLA 2008-07-21 11:40:38 EDT 
When I create a sequence on my PostgreSQL database then query for it via org.eclipse.datatools.modelbase.sql.schema.Schema#getSequences() only an empty collection is returned.
Comment 1 Brian Fitzpatrick CLA 2008-07-21 12:33:17 EDT 
Setting to future. Hopefully we can get some help with the PostgreSQL support
Comment 2 Pierre Queinnec CLA 2011-08-07 13:47:39 EDT 
Hi guys, the following patch hopefully makes DTP support PostgreSQL sequences.
Let me know if it looks good or not. If it fits, I'll come up with other patches for better Postgres support.
Thanks!
Comment 3 Pierre Queinnec CLA 2011-08-07 13:48:14 EDT 
Created attachment 201049 [details]
PG sequences support
Comment 4 Pierre Queinnec CLA 2011-10-05 03:48:02 EDT 
Created attachment 204568 [details]
Patch in EGit default format

Patch exported without checking Git format in EGit.
Comment 5 Brian Payton CLA 2011-10-06 15:55:33 EDT 
It's odd, but the patch file itself doesn't have any indication inside it as to which projects the patch changes apply.  This seems like an EGit bug to me.  (When creating a patch file with CVS, the patch file includes "#P <plugin name>" records.)

I was able to apply the patch, but I had to figure out which changes apply to which plugins, and apply the patch twice.

It would be helpful for future patches to create the patch for one plugin at a time, and indicate which plugin it applies to (perhaps as part of the patch name).
Comment 6 Brian Payton CLA 2011-10-06 16:07:26 EDT 
Another odd thing:  created a local branch "Bug359861" for these changes, based on my local master branch.  When I applied the changes for the patch, the file updates went into the Bug branch, but new files that I had to do an "Add" for went into my local master branch.  That seems like another EGit bug to me.

I'll keep my fingers crossed that everything will flow through OK when I merge the Bug branch into my local master branch and then push everything to the remote repository.
Comment 7 Brian Payton CLA 2011-10-06 16:12:54 EDT 
Well, I might be wrong about the Add acting differently from other updates.  One way or another, the changes got into my local master.