Bugzilla – Full Text Bug Listing
| Summary: | [jres] Search VM does nothing | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Dani Megert <daniel_megert> |
| Component: | Debug | Assignee: | Joe Szurszewski <eclipse> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | darin.eclipse |
| Version: | 2.0 | ||
| Target Milestone: | 2.1 M2 | ||
| Hardware: | PC | ||
| OS: | Windows 2000 | ||
| Whiteboard: | |||
| Bug Depends on: | 22643 | ||
| Bug Blocks: | |||
|
Description
Dani Megert
Fixed for the case of "My Documents" and "Desktop". Added an info dialog if not JREs were found. Does not work for "My Computer" and "My Network Places" as those selections return "null" from the DirectoryDialog.open(), which is supposed to indicate "cancel". Fixed as much as possible. Please verify, Joe. Do you see anyway to solve the "My Computer/My Network Places" problem? Note: My Documents works for me. I hope this will continue to work ;-) Seems not be fixed in I20021001:
Desktop -> dialog says: "No JREs found in..."
My Computer -> nothing happens [state as can't be fixed in the PR]
My Network places -> nothing happens [state as can't be fixed in the PR]
My Documents -> OK
The message (for Desktop) is very confusing for the user: a Windows (and any
other tree view) user is used to the fact given
Desktop
+ My Computer
+ Win2k (C:)
and I select "Desktop" or "My Computer" and then search for something I also get
the results found in "Win2k (C:)". If it is not possible to do so then the
warning should tell exactly this. Saying that nothing is found is confusing. I
could assume that there aren't any VMs at all.
Couldn't you disable the button if DirectoryDialog.open() returns null for the
selected item?
Maybe there's another way/API to browse the file system?
Darin, did your fix make it into 20021001? The fix is in. The problem is with the DirectoryDialog. Requires investigation. The problem with the directory dialog is marked as "wont fix" by SWT - bug# 22643. I disagree.... The message for "Desktop" and "My Documents" is not misleading. The message states that no JREs were found, and states where we searched (which is the location returned by the directory dialog). The bogosity is with the directory dialog, which we do not intend to re-write. Won't fix. What about a hint that sub components might answer results? I still think the text is not goood enough. Let me give an example: What would you say if I change Java or text search to show a dialog "No matches found in project A" in the following case: 1. Select project A which has folder texts with a.txt that contains "test" 2. Open Search dialog - switch to Text search page 3. Check scope "Selected Resources" 4. Search for text "test" Even though the dialog would say where it did not find the matches (in project A) I assume you would not accept this as acceptable behavior for the Search component. Re-open to mark as later. I agree that it would be nice to do better. But I also think that the root of the problem is the DirectoryDialog. No action planned immediately. Closing We can't tell the difference between cancel and "My Computer". |