Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 241211

Summary: Show author, date and comment next in compare editors
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: TeamAssignee: Dani Megert <daniel_megert>
Status: CLOSED WONTFIX QA Contact:
Severity: enhancement    
Priority: P5 CC: james.cooper, kumar, pawel.pogorzelski1, Szymon.Brandys, tomasz.zarna
Version: 3.0Keywords: helpwanted
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: stalebug
Bug Depends on: 57468    
Bug Blocks:    
Attachments:
Description Flags
Adds comment to ResourceDiffCompareInput and FileRevisionTypedElement none

Description Dani Megert CLA 2008-07-17 05:20:25 EDT
+++ This bug was initially created as a clone of Bug #57468 +++

R3.4.

Bug 75468 got marked as FIXED but it is definitely not. Only the author is shown but neither the date nor the commit comment.

This is justified in bug 57468 with:
> Also, the date and commit 
>comment are not shown becuase of the lack of space where the information is 
>displayed.

I disagree with that. Like the author, the commit comment and the date can be very important information and if a user decides to need it, it will love to pay for the additional required space (e.g. an additional line below the revision).

Currently my workflow when reviewing incoming changes is:

1. click on file in Synchronize view
2. click on History fast view icon to see the comment
3. look at the changes

Yes, I could pin the History view (i.e. not have it as fast view) but then the horizontal space for the compare editor becomes very small.

Also, another approach would be to show this information when hovering over the revision (area).
Comment 1 Tomasz Zarna CLA 2008-07-17 07:19:59 EDT
Dani, are you able to display the file author in a compare editor? I did turn on the option mentioned by Michael in bug 57468, comment 6 (btw, don't know why, but it's in Team preferences page now) but I can see no difference.
Comment 2 Dani Megert CLA 2008-07-17 08:49:58 EDT
>Dani, are you able to display the file author in a compare editor?
Yes, but it depends how you open it (argh!), see bug 80577.

Open it via Synchronize view.
Comment 3 Dani Megert CLA 2008-07-17 08:53:13 EDT
Created attachment 107725 [details]
Adds comment to ResourceDiffCompareInput and FileRevisionTypedElement

First step: enhances the model with a comment.
Comment 4 Pawel Pogorzelski CLA 2008-12-01 10:47:55 EST
No time to address the issue now. However I'm keen provide help in case someone creates a patch.
Comment 5 Dani Megert CLA 2010-09-15 02:37:02 EDT
I'd like to see at least the comment. I'll see what I can do for 3.7.
Comment 6 Szymon Brandys CLA 2011-04-04 05:18:10 EDT
(In reply to comment #5)
> I'd like to see at least the comment. I'll see what I can do for 3.7.

Dani, is it still in the 3.7 plan?
Comment 7 Dani Megert CLA 2011-04-04 05:19:45 EDT
(In reply to comment #6)
> (In reply to comment #5)
> > I'd like to see at least the comment. I'll see what I can do for 3.7.
> 
> Dani, is it still in the 3.7 plan?

No, I won't have time to address this.
Comment 8 Lars Vogel CLA 2019-11-14 03:18:08 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.