Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 240441

Summary:

[wikitext] specify implementation for Java resource

Product:

z_Archived

Reporter:

Jingwen 'Owen' Ou <jingweno>

Component:

Mylyn

Assignee:

Jingwen 'Owen' Ou <jingweno>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

steffen.pingel

Version:

unspecified

Target Milestone:

3.0.2

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

239087

Attachments:

Description	Flags
detecting Java resource	none
mylyn/context/zip	none
a patch with better comments and renaming getResourceExpressions()	none
mylyn/context/zip	none
corresponding extension plugin.xml	none

Description Jingwen 'Owen' Ou

2008-07-10 23:46:38 EDT

Specify implementation for Java resource as described on bug 239087. Require bug 240423.

Comment 1 Jingwen 'Owen' Ou

2008-07-10 23:51:25 EDT

Created attachment 107163 [details]
detecting Java resource

Comment 2 Jingwen 'Owen' Ou

2008-07-10 23:51:27 EDT

Created attachment 107164 [details]
mylyn/context/zip

Comment 3 Jingwen 'Owen' Ou

2008-07-10 23:57:44 EDT

*** Bug 240440 has been marked as a duplicate of this bug. ***

Comment 4 Jingwen 'Owen' Ou

2008-07-10 23:57:56 EDT

*** Bug 240439 has been marked as a duplicate of this bug. ***

Comment 5 Jingwen 'Owen' Ou

2008-07-10 23:58:05 EDT

*** Bug 240438 has been marked as a duplicate of this bug. ***

Comment 6 Jingwen 'Owen' Ou

2008-07-10 23:58:12 EDT

*** Bug 240437 has been marked as a duplicate of this bug. ***

Comment 7 Steffen Pingel

2008-07-21 20:13:52 EDT

Looks great. Here two suggestions for improvement:

- The JavaDoc comments should be full sentences, e.g. "Extracts the resource name for the matched text. Subclasses should override this method if... ." This page has more detailed information about writing JavaDoc comments and good examples: http://java.sun.com/j2se/javadoc/writingapispecs/index.html .
- AbstractResourceHyperlinkExtension.getReourceExpressions() should be renamed to getResourceExpressions().

Comment 8 Jingwen 'Owen' Ou

2008-07-22 15:51:02 EDT

Created attachment 108124 [details]
a patch with better comments and renaming getResourceExpressions()

thanks Steffen for the helpful comments :).

Comment 9 Jingwen 'Owen' Ou

2008-07-22 15:51:04 EDT

Created attachment 108125 [details]
mylyn/context/zip

Comment 10 Steffen Pingel

2008-07-23 19:25:47 EDT

Thanks for the updated patch. I have committed it. Can you post another patch for the corresponding extension in the plugin.xml?

Comment 11 Jingwen 'Owen' Ou

2008-07-23 19:52:17 EDT

Created attachment 108289 [details]
corresponding extension plugin.xml

Comment 12 Steffen Pingel

2008-07-23 20:41:41 EDT

Please include this on another patch including that includes the missing files on bug 239087.