Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 239493

Summary: [api tooling] API Baseline does not pick up stuff from dropins/
Product: [Eclipse Project] PDE Reporter: Martin Oberhuber <mober.at+eclipse>
Component: API ToolsAssignee: PDE API Tools Inbox <pde-apitools-inbox>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: darin.eclipse, Michael_Rennie
Version: 3.4Flags: Michael_Rennie: review+
Target Milestone: 3.5 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch none

Description Martin Oberhuber CLA 2008-07-03 13:44:25 EDT 
Build ID: I20080617-2000 (Eclipse 3.4)

In API Tooling Preferences, Baseline, pick an Eclipse installation that has some additions installed into dropins/

These additions are not picked up by the baseline.

Workaround: Install everything into plugins/
Comment 1 Darin Wright CLA 2008-07-03 15:26:35 EDT 
The baseline should be discovered using p2/runtime reflection to determine what bunldes are part of an install/configuration. PDE will migrate to use similar technology when discovering a target platform, and API tooling should follow.
Comment 2 Darin Wright CLA 2008-12-03 13:27:35 EST 
Marking as M5 candidate.
Comment 3 Darin Wright CLA 2009-01-26 10:29:39 EST 
Yeah - this will be pushed to M6 and will work of the new PDE target support that is going into M5.
Comment 4 Darin Wright CLA 2009-02-23 12:05:39 EST 
Created attachment 126479 [details]
patch

This fix uses PDE's new target definition model to retrieve installed bundles from the specified baseline location. If the location is not an installation, directory scanning proceeds as before.
Comment 5 Darin Wright CLA 2009-02-23 12:11:41 EST 
We have had some discussion on the topic of baseline definition. Really, a baseline is just a target and could be composed the same way as a target definition (i.e. see new target platform preference page). For API analysis, the target is used for comparison rather than compilation.

This patch just changes the way the initial set of bundles is fed into a baseline.

Moving forward we should consider combining the target plaform and API baseline preference pages into one. Generally, when someonne defines a target platform for building, they should also define an API baseline. They could be managed in the same place. We could allow a baseline to be defined by a target definition file, similar to target platforms.
Comment 6 Darin Wright CLA 2009-02-23 13:05:22 EST 
Released fix to HEAD. Please verify, Mike.
Comment 7 Michael Rennie CLA 2009-03-03 10:38:14 EST 
verified