Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 239159

Summary: The shell process subsystem not working without the shells subsystem present for the systemType
Product: [Tools] Target Management Reporter: Yufen Kuo <ykuo>
Component: RSEAssignee: Anna Dushistova <anna.dushistova>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: mober.at+eclipse
Version: 3.0   
Target Milestone: 3.0.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 227574    
Attachments:
Description Flags
patch that fixes the issue mober.at+eclipse: review+

Description Yufen Kuo CLA 2008-07-01 15:15:30 EDT 
Build ID: I20080330-1350

this is related to bug 239158. Currently, the Shell process subsystem is built on top of the shells subsystem, if the shells subsystem is being replaced by terminals subsystem, then it does not get displayed in the remote system explorer view anymore. 

Is there anyway we can decouple this relation and have a more generic command subsystem that is the base of the terminal and shell subsystem and have the shell process subsystem use that instead.
Comment 1 Martin Oberhuber CLA 2008-07-01 15:18:47 EDT 
I'm sure we can :-) -- My idea was that 

  (1) The shell processes subsystem doesn't look for a ShellServiceSubSystem
      like it does now, but it looks for any kind of ISubSystem that provides
      an IService that is adaptable to an IShellService
  (2) We provide an Adapter that can adapt any kind of ITerminalService to an 
      IShellService

There might be yet better ways doing this (e.g. I'm not 100% sure whether it wouldn't be better to have the Shell Processes Subsystem use an ITerminalService as its underlying mechanism, and potentially adapt the IShellService to an ITerminalService).
Comment 2 Anna Dushistova CLA 2008-07-11 07:32:07 EDT 
Created attachment 107191 [details]
patch that fixes the issue

Martin, could you please review the fix?
Comment 3 Martin Oberhuber CLA 2008-07-11 13:36:33 EDT 
Comment on attachment 107191 [details]
patch that fixes the issue

Very nice indeed! Was easier than expected, eh? I only found two really minor glitches that you should fix before committing:

DelegatingShellProcessConnectorService:
 - In Copyright Header, add "...and others" to first line of Copyright
Manifest.mf
 - Bundle-version must now be 1.1.1.qualifier

Over all, excellent work!
Comment 4 Anna Dushistova CLA 2008-07-11 13:53:05 EDT 
(In reply to comment #3)
> (From update of attachment 107191 [details])
> Very nice indeed! Was easier than expected, eh?

Yes.:) I fixed the issues mentioned and commited the fix.
Comment 5 Martin Oberhuber CLA 2008-07-11 13:58:16 EDT 
*** Bug 227574 has been marked as a duplicate of this bug. ***