Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 238084

Summary:	[PHP Modeling] Migrate PHPFunctionsPart to work with the new model
Product:	z_Archived	Reporter:	Roy Ganor <ganoro>
Component:	PDT	Assignee:	Eden Klein <eden>
Status:	CLOSED FIXED	QA Contact:	Sylvia Tancheva <silviya>
Severity:	normal
Priority:	P1	CC:	gadi, ganoro, guy.g, spektom
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:	252155
Bug Blocks:

Description Roy Ganor

2008-06-23 05:21:44 EDT

should be adapted to the new model

Comment 1 Alon Peled

2008-07-07 03:42:49 EDT

PHP Functions view reimplemented.
It is now based on the current open editor - it updates the PHP version (4 or 5) according to the settings of the project.

Comment 2 Gadi Goldbarg

2008-10-05 05:40:04 EDT

in I20080924:

Still did not see the change between them (4 and 5) + missing menu icon to 
switch + should not show constants

Comment 3 Roy Ganor

2008-10-16 08:07:48 EDT

Guy,

Please decide on this feature request that was inherited from PDT 1.0.

The issue that we don't have the language model until the project is set to PHP4 version hence we can't show the language model when the project is PHP5.

I don't see any point in showing the PHP4 language model when the project is PHP5. (apparently Gadi see the point :-))

Comment 4 Gadi Goldbarg

2008-10-16 08:30:42 EDT

not a bug...eclipse way

Comment 5 Gadi Goldbarg

2008-10-16 08:32:14 EDT

not a bug

Comment 6 Gadi Goldbarg

2008-10-16 08:41:29 EDT

After further discussion:

1. The view needs to be sorted as follows (alphabetically for each one):
	a. Constants entry -> All constants (under one entry in the tree)
 b. Classes
 c. functions ( with no + for them)

2. When editors are closed it should change according to focused element in PHP 
explorer

Comment 7 Eden Klein

2008-10-27 05:57:44 EDT

Added a bug (with patch fixing it) to dltk and added dependency

Comment 8 Eden Klein

2008-10-28 11:57:44 EDT

fixed in dltk - already in integration build

Comment 9 Gadi Goldbarg

2008-10-29 09:45:45 EDT

take a look at the parenthesis

Comment 10 Roy Ganor

2008-11-02 07:44:02 EST

targeting to PDT 2.0 M2

Comment 11 Eden Klein

2008-11-03 07:20:44 EST

fixed.
1)filter out method variables
2) group all constant under "constants" item at the head of the list

Comment 12 Gadi Goldbarg

2008-11-05 06:44:38 EST

Verified on build N20081104
Closing
[Sylvia Tancheva]